diff mbox series

[v2,1/3] uboot-envtools: add support for GS108T v3 & GS110TPP v1

Message ID 20210408103348.26561-2-foss@volatilesystems.org
State Not Applicable
Headers show
Series Realtek: various fixes | expand

Commit Message

Stijn Segers April 8, 2021, 10:33 a.m. UTC
The Netgear GS108T v3 and its GS110TPP v1 sibling apparently label their
u-boot environment parition 'bdinfo' instead of 'u-boot-env'.

Signed-off-by: Stijn Segers <foss@volatilesystems.org>
---
 package/boot/uboot-envtools/files/realtek | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Stijn Segers April 8, 2021, 11:10 a.m. UTC | #1
Hi,

Op donderdag 8 april 2021 om 12u33 schreef Stijn Segers 
<foss@volatilesystems.org>:
> The Netgear GS108T v3 and its GS110TPP v1 sibling apparently label 
> their
> u-boot environment parition 'bdinfo' instead of 'u-boot-env'.
> 

I was still carrying prior to Bjorn's last rebase, but this isn't 
needed anymore. Both devices fully match the generic case. Will update 
accordingly in Patchwork.

Cheers

Stijn



> Signed-off-by: Stijn Segers <foss@volatilesystems.org>
> ---
>  package/boot/uboot-envtools/files/realtek | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/boot/uboot-envtools/files/realtek 
> b/package/boot/uboot-envtools/files/realtek
> index 75a399208e..0ee81fe791 100644
> --- a/package/boot/uboot-envtools/files/realtek
> +++ b/package/boot/uboot-envtools/files/realtek
> @@ -22,6 +22,12 @@ zyxel,gs1900-10hp)
>  	[ -n "$idx2" ] && \
>  		ubootenv_add_uci_sys_config "/dev/mtd$idx2" "0x0" "0x1000" 
> "0x10000"
>  	;;
> +netgear,gs108t-v3|\
> +netgear,gs110tpp-v1)
> +	idx="$(find_mtd_index u-boot-env)"
> +	[ -n "$idx" ] && \
> +		ubootenv_add_uci_config "/dev/mtd$idx" "0x0" "0x10000" "0x10000"
> +	;;
>  *)
>  	idx="$(find_mtd_index u-boot-env)"
>  	[ -n "$idx" ] && \
> --
> 2.30.2
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Adrian Schmutzler April 10, 2021, 4:44 p.m. UTC | #2
> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Stijn Segers
> Sent: Donnerstag, 8. April 2021 13:10
> To: openwrt-devel@lists.openwrt.org
> Cc: hauke@hauke-m.de
> Subject: Re: [PATCH v2 1/3] uboot-envtools: add support for GS108T v3 &
> GS110TPP v1
> 
> Hi,
> 
> Op donderdag 8 april 2021 om 12u33 schreef Stijn Segers
> <foss@volatilesystems.org>:
> > The Netgear GS108T v3 and its GS110TPP v1 sibling apparently label
> > their u-boot environment parition 'bdinfo' instead of 'u-boot-env'.
> >
> 
> I was still carrying prior to Bjorn's last rebase, but this isn't needed anymore.
> Both devices fully match the generic case. Will update accordingly in
> Patchwork.

Okay, because I was wondering why you talk about bdinfo being needed and then add code based on u-boot-env below ...

Best

Adrian

> 
> Cheers
> 
> Stijn
> 
> 
> 
> > Signed-off-by: Stijn Segers <foss@volatilesystems.org>
> > ---
> >  package/boot/uboot-envtools/files/realtek | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/package/boot/uboot-envtools/files/realtek
> > b/package/boot/uboot-envtools/files/realtek
> > index 75a399208e..0ee81fe791 100644
> > --- a/package/boot/uboot-envtools/files/realtek
> > +++ b/package/boot/uboot-envtools/files/realtek
> > @@ -22,6 +22,12 @@ zyxel,gs1900-10hp)
> >  	[ -n "$idx2" ] && \
> >  		ubootenv_add_uci_sys_config "/dev/mtd$idx2" "0x0"
> "0x1000"
> > "0x10000"
> >  	;;
> > +netgear,gs108t-v3|\
> > +netgear,gs110tpp-v1)
> > +	idx="$(find_mtd_index u-boot-env)"
> > +	[ -n "$idx" ] && \
> > +		ubootenv_add_uci_config "/dev/mtd$idx" "0x0" "0x10000"
> "0x10000"
> > +	;;
> >  *)
> >  	idx="$(find_mtd_index u-boot-env)"
> >  	[ -n "$idx" ] && \
> > --
> > 2.30.2
> >
> >
> > _______________________________________________
> > openwrt-devel mailing list
> > openwrt-devel@lists.openwrt.org
> > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> 
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/package/boot/uboot-envtools/files/realtek b/package/boot/uboot-envtools/files/realtek
index 75a399208e..0ee81fe791 100644
--- a/package/boot/uboot-envtools/files/realtek
+++ b/package/boot/uboot-envtools/files/realtek
@@ -22,6 +22,12 @@  zyxel,gs1900-10hp)
 	[ -n "$idx2" ] && \
 		ubootenv_add_uci_sys_config "/dev/mtd$idx2" "0x0" "0x1000" "0x10000"
 	;;
+netgear,gs108t-v3|\
+netgear,gs110tpp-v1)
+	idx="$(find_mtd_index u-boot-env)"
+	[ -n "$idx" ] && \
+		ubootenv_add_uci_config "/dev/mtd$idx" "0x0" "0x10000" "0x10000"
+	;;
 *)
 	idx="$(find_mtd_index u-boot-env)"
 	[ -n "$idx" ] && \