[OpenWrt-Devel,v3] base-files: For sysfixtime use hwclock if RTC available

From: Daniel Dickinson <openwrt@daniel.thecshore.com>

On systems that have an RTC prefer it to the file-based time fixup (i.e.
use hwclock when there is a permanent clock instead of the faked up time
logic that is needed when there is not RTC).

We can't rely on hctosys kernel feature either as we're usually using
RTC as kernel modules which are usually being loaded after hctosys was
run, leading in the following error:

  hctosys: unable to open rtc device (rtc0)

Signed-off-by: Daniel Dickinson <openwrt@daniel.thecshore.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
---

Changes in v3:
 * uppercased global variables

 package/base-files/files/etc/init.d/sysfixtime |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

* Petr Štetiar <ynezz@true.cz> [21.01.2016 12:22]:
>  boot() {
> +	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ] && $HWCLOCK -s -f $RTC_DEV && exit 0

thank you! can you please do in this line a:
&& return

and introduce a helper (maybe overengineered 8-)

deps_ok() {
	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ]
}

bye, bastian

On 21/01/2016 12:53, Bastian Bittorf wrote:
> * Petr Štetiar <ynezz@true.cz> [21.01.2016 12:22]:
>>  boot() {
>> +	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ] && $HWCLOCK -s -f $RTC_DEV && exit 0
> 
> thank you! can you please do in this line a:
> && return
> 
> and introduce a helper (maybe overengineered 8-)
> 
> deps_ok() {
> 	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ]
> }
> 
> bye, bastian

hang on there, this looks like bastel basti scriptowahn

* John Crispin <blogic@openwrt.org> [21.01.2016 13:30]:
> hang on there, this looks like bastel basti scriptowahn

8-) but the 'exit VS. return' is valid...

bye, bastian

Bastian Bittorf <bittorf@bluebottle.com> [2016-01-21 12:53:48]:

> * Petr Štetiar <ynezz@true.cz> [21.01.2016 12:22]:
> >  boot() {
> > +	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ] && $HWCLOCK -s -f $RTC_DEV && exit 0
> 
> thank you! can you please do in this line a:
> && return

Like following?

	deps_ok && $HWCLOCK -s -f $RTC_DEV && exit 0 && return 

Is it really needed? I've always thought, that exit will terminate the script
so the return wouldn't be called anyway.

> and introduce a helper (maybe overengineered 8-)

Kind of, was thinking about it also so I'll change it, thanks.

> deps_ok() {
> 	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ]
> }

-- ynezz

On 26/01/2016 21:35, Petr Štetiar wrote:
> Bastian Bittorf <bittorf@bluebottle.com> [2016-01-21 12:53:48]:
> 
>> * Petr Štetiar <ynezz@true.cz> [21.01.2016 12:22]:
>>>  boot() {
>>> +	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ] && $HWCLOCK -s -f $RTC_DEV && exit 0
>>
>> thank you! can you please do in this line a:
>> && return
> 
> Like following?
> 
> 	deps_ok && $HWCLOCK -s -f $RTC_DEV && exit 0 && return 
> 
> Is it really needed? I've always thought, that exit will terminate the script
> so the return wouldn't be called anyway.
> 
>> and introduce a helper (maybe overengineered 8-)
> 
> Kind of, was thinking about it also so I'll change it, thanks.
> 
>> deps_ok() {
>> 	[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ]
>> }
> 
> -- ynezz

please don't add a helper. instead just call start from boot, honour its
return code and then decide if you want to run the exising code.

	John

> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>

* Petr Štetiar <ynezz@true.cz> [28.01.2016 11:06]:
> Like following?
> 
> 	deps_ok && $HWCLOCK -s -f $RTC_DEV && exit 0 && return 

just:
deps_ok && $HWCLOCK -s -f $RTC_DEV && return

bye, bastian