| Message ID | 1450062272-7026-6-git-send-email-mar.kolya@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
On 14/12/2015 04:04, Nikolay Martynov wrote: > It's unlikely that devices on this SoC would need any ISDN support. > This should make kernel a bit smaller. > > Signed-off-by: Nikolay Martynov <mar.kolya@gmail.com> > --- > target/linux/ramips/mt7621/config-4.3 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/linux/ramips/mt7621/config-4.3 b/target/linux/ramips/mt7621/config-4.3 > index a56395c..6be42a2 100644 > --- a/target/linux/ramips/mt7621/config-4.3 > +++ b/target/linux/ramips/mt7621/config-4.3 > @@ -114,6 +114,7 @@ CONFIG_IRQ_DOMAIN=y > CONFIG_IRQ_FORCED_THREADING=y > CONFIG_IRQ_MIPS_CPU=y > CONFIG_IRQ_WORK=y > +# CONFIG_ISDN is not set > CONFIG_LIBFDT=y > CONFIG_LZO_COMPRESS=y > CONFIG_LZO_DECOMPRESS=y > ah you found my easter egg. this has been in our config for ages for some reason beyond my knowledge ;) thanks for the patches i'll go over them during the day
* John Crispin <blogic@openwrt.org> [14.12.2015 09:19]: > > +# CONFIG_ISDN is not set > > ah you found my easter egg. this has been in our config for ages for > some reason beyond my knowledge ;) using OpenWrt as an ISDN-dialup/concentrator is not totally out of scope, but nowadays it's at least exotic... bye, bastian
On 2015-12-14 04:04, Nikolay Martynov wrote: > It's unlikely that devices on this SoC would need any ISDN support. > This should make kernel a bit smaller. > > Signed-off-by: Nikolay Martynov <mar.kolya@gmail.com> NACK from me on this one. I don't want people to fill up the target configs with random arbitrary overrides based on what kind of use cases people think may or may not be possible with devices from that target. If CONFIG_ISDN really does have an effect on kernel size, there should be a generic way to deal with this, or a way to confine the size impact on the actual kernel modules using it. Did you find any actual size impact in your tests, or were you just guessing? - Felix
2015-12-14 4:54 GMT-05:00 Felix Fietkau <nbd@openwrt.org>: > On 2015-12-14 04:04, Nikolay Martynov wrote: >> It's unlikely that devices on this SoC would need any ISDN support. >> This should make kernel a bit smaller. >> >> Signed-off-by: Nikolay Martynov <mar.kolya@gmail.com> > NACK from me on this one. I don't want people to fill up the target > configs with random arbitrary overrides based on what kind of use cases > people think may or may not be possible with devices from that target. > > If CONFIG_ISDN really does have an effect on kernel size, there should > be a generic way to deal with this, or a way to confine the size impact > on the actual kernel modules using it. > > Did you find any actual size impact in your tests, or were you just > guessing? Please feel free to drop this. I've just done some measurements and it looks like it's 1 page a most, and it's probably stripped after that. It's just somewhat to see ISDN in configs nowdays and it looks like other targets' configs drop this support. Sorry, should have checked size effects before submitting.
diff --git a/target/linux/ramips/mt7621/config-4.3 b/target/linux/ramips/mt7621/config-4.3 index a56395c..6be42a2 100644 --- a/target/linux/ramips/mt7621/config-4.3 +++ b/target/linux/ramips/mt7621/config-4.3 @@ -114,6 +114,7 @@ CONFIG_IRQ_DOMAIN=y CONFIG_IRQ_FORCED_THREADING=y CONFIG_IRQ_MIPS_CPU=y CONFIG_IRQ_WORK=y +# CONFIG_ISDN is not set CONFIG_LIBFDT=y CONFIG_LZO_COMPRESS=y CONFIG_LZO_DECOMPRESS=y
It's unlikely that devices on this SoC would need any ISDN support. This should make kernel a bit smaller. Signed-off-by: Nikolay Martynov <mar.kolya@gmail.com> --- target/linux/ramips/mt7621/config-4.3 | 1 + 1 file changed, 1 insertion(+)