| Message ID | 20210707084321.1044138-3-mark.d.gray@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dpif-netlink: Introduce per-cpu upcall dispatching | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot | success | github build: passed |
Mark Gray <mark.d.gray@redhat.com> writes: > Fixes: 1579cf677fcb ("dpif-linux: Implement the API functions to allow multiple handler threads read upcall.") > Signed-off-by: Mark Gray <mark.d.gray@redhat.com> > Acked-by: Flavio Leitner <fbl@sysclose.org> > --- > > Notes: > v1 - Reworked based on Flavio's comments: > * Added "Fixes" tag > > lib/dpif-netlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > WOW! This is an old fix. I guess this must have been flagged by some compiler update. I don't think it's really part of 'per-cpu support' - it should definitely be merged, though. Acked-by: Aaron Conole <aconole@redhat.com>
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 73d5608a81a2..f92905dd83fd 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -4666,7 +4666,7 @@ report_loss(struct dpif_netlink *dpif, struct dpif_channel *ch, uint32_t ch_idx, time_msec() - ch->last_poll); } - VLOG_WARN("%s: lost packet on port channel %u of handler %u", - dpif_name(&dpif->dpif), ch_idx, handler_id); + VLOG_WARN("%s: lost packet on port channel %u of handler %u%s", + dpif_name(&dpif->dpif), ch_idx, handler_id, ds_cstr(&s)); ds_destroy(&s); }
Fixes: 1579cf677fcb ("dpif-linux: Implement the API functions to allow multiple handler threads read upcall.") Signed-off-by: Mark Gray <mark.d.gray@redhat.com> Acked-by: Flavio Leitner <fbl@sysclose.org> --- Notes: v1 - Reworked based on Flavio's comments: * Added "Fixes" tag lib/dpif-netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)