From patchwork Wed Jul 7 08:43:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Gray X-Patchwork-Id: 1501634 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TwctA8WE; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GKXyL2BZ4z9sWS for ; Wed, 7 Jul 2021 18:43:38 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1F1B34063E; Wed, 7 Jul 2021 08:43:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ePu2j8ufnUTr; Wed, 7 Jul 2021 08:43:33 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9BC9B40657; Wed, 7 Jul 2021 08:43:31 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7D8A3C0026; Wed, 7 Jul 2021 08:43:30 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 05994C000E for ; Wed, 7 Jul 2021 08:43:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E6CF640637 for ; Wed, 7 Jul 2021 08:43:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F6_ioJqZWwhg for ; Wed, 7 Jul 2021 08:43:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1950C40543 for ; Wed, 7 Jul 2021 08:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625647407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=axVD52BHX/mA9RrUQneC9qPc1QJyLVlom7Ixl92g6TU=; b=TwctA8WEZmVB9oQ079sxuwFg7qvkfCufDmkYPfHL6hRhac+NKNw9w3NzCudmPRazqnC30S F6kUHZfzbBav7DU+DE1LYPGLsVpjgz1/SAFIkszrkZb2B5n7i+Lt7o9X6fn5PIhNcq+hYu 35J+29AD3+x3d00iIOfnF03bQfgcWdg= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-VPSzPW8jP9GG0E6kGhTXtg-1; Wed, 07 Jul 2021 04:43:26 -0400 X-MC-Unique: VPSzPW8jP9GG0E6kGhTXtg-1 Received: by mail-qt1-f199.google.com with SMTP id q16-20020ac845100000b0290252006e22f6so846103qtn.22 for ; Wed, 07 Jul 2021 01:43:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=axVD52BHX/mA9RrUQneC9qPc1QJyLVlom7Ixl92g6TU=; b=GaL4j5fS5YnmR4GjtNLG7Y2wTtgG1ew0rU1oAoqlMoDpJv4+c5sc64hsM0xcWBcU7k o0hJbb5J4spHO9vjznpP4uHH1pIcXnEVcSNI1KpUjnF9G3pRk7UsxoJEBj9KCXXbOb7m n/osGCzUFqvF02uXax8f9yRQSQCGrQvETcj7skOqXQz8Jf7gWNjmmuD6nLkvueX9szSX RRprwZZ7pzknsiGHu6XXe8b7XbDmcRPNXW6gBkRwf3HuRrySXJIAecVocj+SA+q1kLvk WrFCGGTaOSXxku16RHWe24mywb+NAPDmpl+Fg6B4PZjxeCJ6OI4Gw/dxxNJiO1Q5deRf QJ1Q== X-Gm-Message-State: AOAM532rKR5HPAwv4JkvYiB7hZZNV41m9q4g6d9jxZCz1yKW/pDvDHo0 855AQ+rU+56RKUebxFCngGdVHOakJ/cZXEVWP83FEbt+JYyNNBIU3FnY2hSRl9eOnSmcmWFAk79 RTx7eXc+t2FO3btkbzBJkzMi8B64gyeZigagjGjr4hqDJ1PnivA5T0gYZQPEsqDLwkPSU X-Received: by 2002:a05:622a:170a:: with SMTP id h10mr21180516qtk.276.1625647405338; Wed, 07 Jul 2021 01:43:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHHV9TaUIL3thGr5T+VwJZM8CehOukluKC4bD+fqPXM2RwxRd6o3niAP2lSrFO9/l0UDzNBg== X-Received: by 2002:a05:622a:170a:: with SMTP id h10mr21180505qtk.276.1625647405115; Wed, 07 Jul 2021 01:43:25 -0700 (PDT) Received: from wsfd-netdev76.ntdv.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id p187sm310782qkd.101.2021.07.07.01.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 01:43:24 -0700 (PDT) From: Mark Gray To: dev@openvswitch.org Date: Wed, 7 Jul 2021 04:43:20 -0400 Message-Id: <20210707084321.1044138-3-mark.d.gray@redhat.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210707084321.1044138-1-mark.d.gray@redhat.com> References: <20210707084321.1044138-1-mark.d.gray@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mark.d.gray@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: fbl@sysclose.org, david.marchand@redhat.com Subject: [ovs-dev] [PATCH v5 2/3] dpif-netlink: fix report_loss() message X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Fixes: 1579cf677fcb ("dpif-linux: Implement the API functions to allow multiple handler threads read upcall.") Signed-off-by: Mark Gray Acked-by: Flavio Leitner Acked-by: Aaron Conole --- Notes: v1 - Reworked based on Flavio's comments: * Added "Fixes" tag lib/dpif-netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 73d5608a81a2..f92905dd83fd 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -4666,7 +4666,7 @@ report_loss(struct dpif_netlink *dpif, struct dpif_channel *ch, uint32_t ch_idx, time_msec() - ch->last_poll); } - VLOG_WARN("%s: lost packet on port channel %u of handler %u", - dpif_name(&dpif->dpif), ch_idx, handler_id); + VLOG_WARN("%s: lost packet on port channel %u of handler %u%s", + dpif_name(&dpif->dpif), ch_idx, handler_id, ds_cstr(&s)); ds_destroy(&s); }