diff mbox series

[ovs-dev,2/3] ovn-controller: Remove the run_id check in engine_run

Message ID 20190624095302.10393-1-nusiddiq@redhat.com
State Superseded
Headers show
Series [ovs-dev,1/3] ovn-controller: Omit alert for Port_Binding.external_ids changes | expand

Commit Message

Numan Siddique June 24, 2019, 9:53 a.m. UTC 
From: Numan Siddique <nusiddiq@redhat.com>

engine_node 'en_sb_port_binding' is added as input to engine nodes
  - 'en_runtime_data' with the handler runtime_data_sb_port_binding_handler() and
  - 'en_flow_output' with the handler flow_output_sb_port_binding_handler() nodes.

Also 'en_runtime_data' is input to node 'en_flow_output'.

The function 'engine_run()' returns immediately if the run_id param is same as
the engine_node->run_id. Because of which the handler 'flow_output_sb_port_binding_handler()'
is never called.

This patch removes this check in engine_run().

Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
---
 ovn/lib/inc-proc-eng.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/ovn/lib/inc-proc-eng.c b/ovn/lib/inc-proc-eng.c
index 1ddea1a85..10ebd047b 100644
--- a/ovn/lib/inc-proc-eng.c
+++ b/ovn/lib/inc-proc-eng.c
@@ -124,9 +124,6 @@  engine_ovsdb_node_add_index(struct engine_node *node, const char *name,
 void
 engine_run(struct engine_node *node, uint64_t run_id)
 {
-    if (node->run_id == run_id) {
-        return;
-    }
     node->run_id = run_id;
 
     node->changed = false;