diff mbox series

[ovs-dev,1/3] ovn-controller: Omit alert for Port_Binding.external_ids changes

Message ID 20190624095243.10320-1-nusiddiq@redhat.com
State Superseded
Headers show
Series [ovs-dev,1/3] ovn-controller: Omit alert for Port_Binding.external_ids changes | expand

Commit Message

Numan Siddique June 24, 2019, 9:52 a.m. UTC 
From: Numan Siddique <nusiddiq@redhat.com>

Running the command "ovn-nbctl set logical_switch_port foo external_ids:foo=bar"
results in the incremetal processing engine to recompute the flows on the
chassis where the logical port 'foo' is claimed.

This patch avoids this unnecessary recomputation by omitting the alert for the
Port_Binding.external_ids column.

Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
---
 ovn/controller/ovn-controller.c | 1 +
 1 file changed, 1 insertion(+)

Comments

0-day Robot June 24, 2019, 9:58 a.m. UTC | #1 
Bleep bloop.  Greetings Numan Siddique, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#26 FILE: ovn/controller/ovn-controller.c:1735:
    ovsdb_idl_omit_alert(ovnsb_idl_loop.idl, &sbrec_port_binding_col_external_ids);

Lines checked: 32, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c
index 60190161f..5dbb8f857 100644
--- a/ovn/controller/ovn-controller.c
+++ b/ovn/controller/ovn-controller.c
@@ -1732,6 +1732,7 @@  main(int argc, char *argv[])
 
     ovsdb_idl_track_add_all(ovnsb_idl_loop.idl);
     ovsdb_idl_omit_alert(ovnsb_idl_loop.idl, &sbrec_chassis_col_nb_cfg);
+    ovsdb_idl_omit_alert(ovnsb_idl_loop.idl, &sbrec_port_binding_col_external_ids);
     update_sb_monitors(ovnsb_idl_loop.idl, NULL, NULL, NULL);
 
     stopwatch_create(CONTROLLER_LOOP_STOPWATCH_NAME, SW_MS);