| Message ID | 20190325101249.3756-1-aserdean@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,windows,wmi] Switch from internal port to all ports defined | expand |
Acked-by: Anand Kumar <kumaranand@vmware.com> Thanks, Anand Kumar ---------- Forwarded message --------- From: Alin Gabriel Serdean <aserdean@ovn.org<mailto:aserdean@ovn.org>> Date: Mon, Mar 25, 2019 at 3:13 AM Subject: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined To: <dev@openvswitch.org<mailto:dev@openvswitch.org>> Cc: Danting Liu <dantingl@vmware.com<mailto:dantingl@vmware.com>> This patch changes the way we try to figure out if a port is defined on a given switch. Instead of looking only in the internal ports defined switch to all ports defined. This caused issues when trying to add a Hyper-V container port to a given OVS bridge. Reported-by: Danting Liu <dantingl@vmware.com<mailto:dantingl@vmware.com>> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org<mailto:aserdean@ovn.org>> --- lib/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/wmi.c b/lib/wmi.c index e6dc63cde..44c1d75e9 100644 --- a/lib/wmi.c +++ b/lib/wmi.c @@ -686,7 +686,7 @@ create_wmi_port(char *name) { /* Check if the element already exists on the switch. */ wchar_t internal_port_query[WMI_QUERY_COUNT] = L"SELECT * FROM " - L"Msvm_InternalEthernetPort WHERE ElementName = \""; + L"CIM_EthernetPort WHERE ElementName = \""; wide_name = xmalloc((strlen(name) + 1) * sizeof(wchar_t)); -- 2.21.0.windows.1
Thanks! Applied on master and backported back until branch-2.10. Alin. From: Anand Kumar <kumaranand@vmware.com> Sent: Thursday, August 1, 2019 5:41 AM To: Alin Serdean <aserdean@cloudbasesolutions.com>; dev@openvswitch.org Cc: Danting Liu <dantingl@vmware.com> Subject: Re: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined Acked-by: Anand Kumar <kumaranand@vmware.com <mailto:kumaranand@vmware.com> > Thanks, Anand Kumar
diff --git a/lib/wmi.c b/lib/wmi.c index e6dc63cde..44c1d75e9 100644 --- a/lib/wmi.c +++ b/lib/wmi.c @@ -686,7 +686,7 @@ create_wmi_port(char *name) { /* Check if the element already exists on the switch. */ wchar_t internal_port_query[WMI_QUERY_COUNT] = L"SELECT * FROM " - L"Msvm_InternalEthernetPort WHERE ElementName = \""; + L"CIM_EthernetPort WHERE ElementName = \""; wide_name = xmalloc((strlen(name) + 1) * sizeof(wchar_t));
This patch changes the way we try to figure out if a port is defined on a given switch. Instead of looking only in the internal ports defined switch to all ports defined. This caused issues when trying to add a Hyper-V container port to a given OVS bridge. Reported-by: Danting Liu <dantingl@vmware.com> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> --- lib/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)