| Message ID | 20180821141806.20040-1-aserdean@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tunnel, tests: Sort flow output in ERSPAN v1/v2 metadata | expand |
On Tue, Aug 21, 2018 at 05:18:06PM +0300, Alin Gabriel Serdean wrote: > Sort the flows by input port in the test: > tunnel.at:512: testing tunnel - ERSPAN v1/v2 metadata ... > > This tests fails on Windows due to the hash function sensitivity described > in: > https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350685.html > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> Works here. Acked-by: Ben Pfaff <blp@ovn.org>
On Tue, Aug 21, 2018 at 11:01 AM Ben Pfaff <blp@ovn.org> wrote: > > On Tue, Aug 21, 2018 at 05:18:06PM +0300, Alin Gabriel Serdean wrote: > > Sort the flows by input port in the test: > > tunnel.at:512: testing tunnel - ERSPAN v1/v2 metadata ... > > > > This tests fails on Windows due to the hash function sensitivity described > > in: > > https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350685.html > > > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> > > Works here. > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks for the fix Acked-by: William Tu <u9012063@gmail.com> > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> > On Tue, Aug 21, 2018 at 11:01 AM Ben Pfaff <blp@ovn.org> wrote: > > > > On Tue, Aug 21, 2018 at 05:18:06PM +0300, Alin Gabriel Serdean wrote: > > > Sort the flows by input port in the test: > > > tunnel.at:512: testing tunnel - ERSPAN v1/v2 metadata ... > > > > > > This tests fails on Windows due to the hash function sensitivity described > > > in: > > > https://mail.openvswitch.org/pipermail/ovs-dev/2018- > August/350685.html > > > > > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> > > > > Works here. > > > > Acked-by: Ben Pfaff <blp@ovn.org> > Thanks for the fix > Acked-by: William Tu <u9012063@gmail.com> > Thanks both! I applied it on master and branch-2.10
diff --git a/tests/tunnel.at b/tests/tunnel.at index ae379db12..f5f7afb0a 100644 --- a/tests/tunnel.at +++ b/tests/tunnel.at @@ -583,9 +583,8 @@ dnl test wildcard mask: recevie all v2 regardless of its metadata AT_CHECK([ovs-ofctl del-flows br0 in_port=4,tun_erspan_ver=2,tun_erspan_dir=1,tun_erspan_hwid=0xf/0x1]) AT_CHECK([ovs-ofctl add-flow br0 in_port=4,tun_erspan_ver=2,tun_erspan_dir=0/0,tun_erspan_hwid=0x0/0x0,actions=2]) -AT_CHECK([ovs-ofctl dump-flows br0 | ofctl_strip], +AT_CHECK([ovs-ofctl --sort=in_port dump-flows br0 | ofctl_strip], [0], [dnl -NXST_FLOW reply: in_port=1 actions=output:3 in_port=2 actions=output:4 tun_erspan_ver=1,tun_erspan_idx=0x7,in_port=3 actions=output:1
Sort the flows by input port in the test: tunnel.at:512: testing tunnel - ERSPAN v1/v2 metadata ... This tests fails on Windows due to the hash function sensitivity described in: https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350685.html Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> --- tests/tunnel.at | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)