| Message ID | 20171106101203.10508-1-aserdean@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,v2,1/6] build-windows: Suppress output from MSBuild | expand |
On Mon, Nov 06, 2017 at 12:11:58PM +0200, Alin Gabriel Serdean wrote: > Add `nologo` parameter to MSBuild to suppress the banner. > > This will make tidier log messages. > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> > Acked-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> Are you looking for more reviews? (Should I ask anyone at VMware to review these?)
> -----Original Message----- > From: Ben Pfaff [mailto:blp@ovn.org] > Sent: Tuesday, November 7, 2017 12:16 AM > To: Alin Gabriel Serdean <aserdean@ovn.org> > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2 1/6] build-windows: Suppress output from > MSBuild > > On Mon, Nov 06, 2017 at 12:11:58PM +0200, Alin Gabriel Serdean wrote: > > Add `nologo` parameter to MSBuild to suppress the banner. > > > > This will make tidier log messages. > > > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> > > Acked-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> > > Are you looking for more reviews? (Should I ask anyone at VMware to > review these?) [Alin Serdean] I wanted to bring them up in today's meeting. I will apply them in a couple of days if there are no other reviews.
> -----Original Message----- > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > bounces@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, November 7, 2017 10:44 PM > To: 'Ben Pfaff' <blp@ovn.org>; 'Alin Gabriel Serdean' <aserdean@ovn.org> > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2 1/6] build-windows: Suppress output from > MSBuild > > > -----Original Message----- > > From: Ben Pfaff [mailto:blp@ovn.org] > > Sent: Tuesday, November 7, 2017 12:16 AM > > To: Alin Gabriel Serdean <aserdean@ovn.org> > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH v2 1/6] build-windows: Suppress output > > from MSBuild > > > > On Mon, Nov 06, 2017 at 12:11:58PM +0200, Alin Gabriel Serdean wrote: > > > Add `nologo` parameter to MSBuild to suppress the banner. > > > > > > This will make tidier log messages. > > > > > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> > > > Acked-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com> > > > > Are you looking for more reviews? (Should I ask anyone at VMware to > > review these?) > [Alin Serdean] I wanted to bring them up in today's meeting. I will apply them > in a couple of days if there are no other reviews. I applied the series on master. Thanks for the reviews!
diff --git a/Makefile.am b/Makefile.am index 5ceb382..ebbc045 100644 --- a/Makefile.am +++ b/Makefile.am @@ -406,13 +406,13 @@ CLEANFILES += manpage-dep-check if VSTUDIO_DDK ALL_LOCAL += ovsext ovsext: datapath-windows/ovsext.sln $(srcdir)/datapath-windows/include/OvsDpInterface.h - MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" - MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" CLEAN_LOCAL += ovsext_clean ovsext_clean: datapath-windows/ovsext.sln - MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Clean /property:Configuration="Win8$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" - MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Clean /property:Configuration="Win8.1$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Clean /property:Configuration="Win8$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Clean /property:Configuration="Win8.1$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" endif .PHONY: ovsext diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk index 36018ea..3820041 100644 --- a/datapath-windows/automake.mk +++ b/datapath-windows/automake.mk @@ -86,5 +86,5 @@ EXTRA_DIST += \ datapath-windows/ovsext/resource.h datapath_windows_analyze: all - MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1Analyze" - MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8Analyze" + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1Analyze" + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8Analyze" diff --git a/windows/automake.mk b/windows/automake.mk index 4fec99e..11ab4c7 100644 --- a/windows/automake.mk +++ b/windows/automake.mk @@ -35,7 +35,7 @@ windows_installer: all cp -f $(top_srcdir)/datapath-windows/x64/Win8.1$(VSTUDIO_CONFIG)/package/ovsext.cat windows/ovs-windows-installer/Driver/Win8.1/ovsext.cat cp -f $(top_srcdir)/datapath-windows/x64/Win8.1$(VSTUDIO_CONFIG)/package/ovsext.inf windows/ovs-windows-installer/Driver/Win8.1/ovsext.inf cp -f $(top_srcdir)/datapath-windows/x64/Win8.1$(VSTUDIO_CONFIG)/package/ovsext.sys windows/ovs-windows-installer/Driver/Win8.1/ovsext.sys - MSBuild.exe windows/ovs-windows-installer.sln /target:Build /property:Configuration="Release" /property:Version="$(PACKAGE_VERSION)" + MSBuild.exe windows/ovs-windows-installer.sln //nologo /target:Build /property:Configuration="Release" /property:Version="$(PACKAGE_VERSION)" EXTRA_DIST += \ windows/automake.mk \