| Message ID | 20170912012728.16496-1-aserdean@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Fix sparse error on test-ovn.c | expand |
Thanks Shashank! I applied on master, branch-2.8, branch-2.7, branch-2.6. Alin. > -----Original Message----- > From: Shashank Ram [mailto:rams@vmware.com] > Sent: Tuesday, September 12, 2017 6:56 AM > To: Alin Gabriel Serdean <aserdean@ovn.org>; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] tests: Fix sparse error on test-ovn.c > > > > > > _ > Subject: [ovs-dev] [PATCH] tests: Fix sparse error on test-ovn.c > > Commit d5c70d4bcc344ae10a644b83f1790a0235871efc fixed the MSVC issue > however, introduced a sparse error: > "tests/test-ovn.c:205:43: warning: Using plain integer as NULL pointer" > > Use 'NULL' instead of '0'. > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> > --- > > Acked-by: Shashank Ram <rams@vmware.com>
diff --git a/tests/test-ovn.c b/tests/test-ovn.c index 345fd47..4beb2b8 100644 --- a/tests/test-ovn.c +++ b/tests/test-ovn.c @@ -202,7 +202,7 @@ create_addr_sets(struct shash *addr_sets) static const char *const addrs3[] = { "00:00:00:00:00:01", "00:00:00:00:00:02", "00:00:00:00:00:03", }; - static const char *const addrs4[] = { 0 }; + static const char *const addrs4[] = { NULL }; expr_addr_sets_add(addr_sets, "set1", addrs1, 3); expr_addr_sets_add(addr_sets, "set2", addrs2, 3);
Commit d5c70d4bcc344ae10a644b83f1790a0235871efc fixed the MSVC issue however, introduced a sparse error: "tests/test-ovn.c:205:43: warning: Using plain integer as NULL pointer" Use 'NULL' instead of '0'. Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> --- tests/test-ovn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)