[ovs-dev] dpif-netlink: Remove wrong restriction for offloading 0x1234 eth type

From: Eli Britstein <elibr@mellanox.com>

'dpif_probe_feature' always has DPIF_FP_PROBE flag set. Other probing
code uses dpif_execute() which uses DPIF_OP_EXECUTE, hence never calls
parse_flow_put(). So, this 'if' statement is wrong and should be deleted
as it only forbids offloading of the real legitimate flows with dl_type
0x1234. Dummy flows never reaches this code.

Signed-off-by: Eli Britstein <elibr@mellanox.com>
Acked-by: Roi Dayan <roid@mellanox.com>
---
 lib/dpif-netlink.c | 5 -----
 1 file changed, 5 deletions(-)

On 2019-07-30 6:43 PM, Roi Dayan wrote:
> From: Eli Britstein <elibr@mellanox.com>
> 
> 'dpif_probe_feature' always has DPIF_FP_PROBE flag set. Other probing
> code uses dpif_execute() which uses DPIF_OP_EXECUTE, hence never calls
> parse_flow_put(). So, this 'if' statement is wrong and should be deleted
> as it only forbids offloading of the real legitimate flows with dl_type
> 0x1234. Dummy flows never reaches this code.
> 
> Signed-off-by: Eli Britstein <elibr@mellanox.com>
> Acked-by: Roi Dayan <roid@mellanox.com>
> ---
>  lib/dpif-netlink.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index 985a284267f5..7bc71d6d19d7 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -2005,11 +2005,6 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
>          return err;
>      }
>  
> -    /* When we try to install a dummy flow from a probed feature. */
> -    if (match.flow.dl_type == htons(0x1234)) {
> -        return EOPNOTSUPP;
> -    }
> -
>      in_port = match.flow.in_port.odp_port;
>      dev = netdev_ports_get(in_port, dpif_class);
>      if (!dev) {
> 


Hi Ilya,

I just noticed in patchwork that you sent the same patch.
I didnt see it before sending this one. some ovs-dev mails being filtered on my end for some reason.
so you can ignore this dup patch.

Thanks,
Roi

On 30.07.2019 19:04, Roi Dayan wrote:
> 
> 
> On 2019-07-30 6:43 PM, Roi Dayan wrote:
>> From: Eli Britstein <elibr@mellanox.com>
>>
>> 'dpif_probe_feature' always has DPIF_FP_PROBE flag set. Other probing
>> code uses dpif_execute() which uses DPIF_OP_EXECUTE, hence never calls
>> parse_flow_put(). So, this 'if' statement is wrong and should be deleted
>> as it only forbids offloading of the real legitimate flows with dl_type
>> 0x1234. Dummy flows never reaches this code.
>>
>> Signed-off-by: Eli Britstein <elibr@mellanox.com>
>> Acked-by: Roi Dayan <roid@mellanox.com>
>> ---
>>  lib/dpif-netlink.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
>> index 985a284267f5..7bc71d6d19d7 100644
>> --- a/lib/dpif-netlink.c
>> +++ b/lib/dpif-netlink.c
>> @@ -2005,11 +2005,6 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
>>          return err;
>>      }
>>  
>> -    /* When we try to install a dummy flow from a probed feature. */
>> -    if (match.flow.dl_type == htons(0x1234)) {
>> -        return EOPNOTSUPP;
>> -    }
>> -
>>      in_port = match.flow.in_port.odp_port;
>>      dev = netdev_ports_get(in_port, dpif_class);
>>      if (!dev) {
>>
> 
> 
> Hi Ilya,
> 
> I just noticed in patchwork that you sent the same patch.
> I didnt see it before sending this one. some ovs-dev mails being filtered on my end for some reason.
> so you can ignore this dup patch.

OK. Thanks for working on this anyway and for this reply.

Best regards, Ilya Maximets.