From patchwork Tue Jul 30 15:43:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 1139057 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45yh3040DFz9sBZ for ; Wed, 31 Jul 2019 01:55:07 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 4EBDE3007; Tue, 30 Jul 2019 15:54:21 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 4280E2FE0 for ; Tue, 30 Jul 2019 15:44:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 588DAF1 for ; Tue, 30 Jul 2019 15:43:59 +0000 (UTC) Received: from Internal Mail-Server by MTLPINE2 (envelope-from roid@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Jul 2019 18:43:57 +0300 Received: from r-vnc05.mtr.labs.mlnx (r-vnc05.mtr.labs.mlnx [10.208.0.115]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6UFhvls017487; Tue, 30 Jul 2019 18:43:57 +0300 From: Roi Dayan To: dev@openvswitch.org Date: Tue, 30 Jul 2019 18:43:51 +0300 Message-Id: <1564501431-6043-1-git-send-email-roid@mellanox.com> X-Mailer: git-send-email 2.7.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , Eli Britstein Subject: [ovs-dev] [PATCH] dpif-netlink: Remove wrong restriction for offloading 0x1234 eth type X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Eli Britstein 'dpif_probe_feature' always has DPIF_FP_PROBE flag set. Other probing code uses dpif_execute() which uses DPIF_OP_EXECUTE, hence never calls parse_flow_put(). So, this 'if' statement is wrong and should be deleted as it only forbids offloading of the real legitimate flows with dl_type 0x1234. Dummy flows never reaches this code. Signed-off-by: Eli Britstein Acked-by: Roi Dayan --- lib/dpif-netlink.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 985a284267f5..7bc71d6d19d7 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -2005,11 +2005,6 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put) return err; } - /* When we try to install a dummy flow from a probed feature. */ - if (match.flow.dl_type == htons(0x1234)) { - return EOPNOTSUPP; - } - in_port = match.flow.in_port.odp_port; dev = netdev_ports_get(in_port, dpif_class); if (!dev) {