| Message ID | 1538083900-22428-1-git-send-email-pkusunyifeng@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ovsdb-client: Fix a bug that uses wrong index | expand |
Bleep bloop. Greetings Yifeng Sun, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#22 FILE: ovsdb/ovsdb-client.c:1764:
ovs_fatal(0, "Table \"%s\" has no column %s.", argv[0], argv[i]);
Lines checked: 32, Warnings: 1, Errors: 0
Please check this out. If you feel there has been an error, please email aconole@bytheb.org
Thanks,
0-day Robot
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index ab3aa7c93307..7c8a59d0e749 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -1761,9 +1761,9 @@ do_dump(struct jsonrpc *rpc, const char *database, for (i = 1; i < argc; i++) { node = shash_find(&tschema->columns, argv[i]); if (!node) { - ovs_fatal(0, "Table \"%s\" has no column %s.", argv[0], argv[1]); + ovs_fatal(0, "Table \"%s\" has no column %s.", argv[0], argv[i]); } - shash_add(&custom_columns, argv[1], node->data); + shash_add(&custom_columns, argv[i], node->data); } } else { tables = shash_sort(&schema->tables);
This patch fixes the incorrect index to argv. Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> --- ovsdb/ovsdb-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)