From patchwork Thu Sep 27 21:31:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yifeng Sun X-Patchwork-Id: 975914 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fiXfN+yz"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42Lp2Y3Ghbz9s3Z for ; Fri, 28 Sep 2018 07:33:25 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 0610B10B0; Thu, 27 Sep 2018 21:31:49 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 62C291084 for ; Thu, 27 Sep 2018 21:31:47 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2860E76C for ; Thu, 27 Sep 2018 21:31:47 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id k19-v6so2798903pfi.1 for ; Thu, 27 Sep 2018 14:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=xM3v+Nw98ConYKuQmlRdaWn76qOJOQrXlDhiwRM0B7Q=; b=fiXfN+yzqzjxghYHiGsuR26kmomErTtleCNlUR+CMj46MIGnSogg432BqEPhdXbXOZ epOP/4KOdIBER0c2ehB1uX0c4vekpnbiZsvuJoefqliJUVMldQ9CRIoDvbvo7wdlNA34 iDOpqmYVOExQ1iofQ7mNl8zjEmaX1t3AaUSPmaTdLp003B8IkAt5aUfBY4HNNMs7cSMD 9NZ+IdrjtZPeQVyGvjb5Ht2+4r10zFqVwwUXb9BCgGfz5wab04PmYiKBZPGJNx6u3aKm 4f90T6PF4FmT+/3kzDwkdFK8mtxieTYkiZmqWvhH5vdOzLhzkIYo5VTX1CcF5UDxHPbo MonA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xM3v+Nw98ConYKuQmlRdaWn76qOJOQrXlDhiwRM0B7Q=; b=NEQOUV0rjMYezT5m/iH4ZbGOJBhrwHRoZqamJk6Hyaqn4muqldF87oF/pD8xGKPuuY KgezPAQgIKM2dVW42Z1I4LwG8AiFhCpkfJ/2KWgoSqnMb6Th2IjHX9T9cX1W6kxfm3zi 1OZMMbdE2duHs2OTDWpRy0Zi6ez2UO3HhBVlyO4vAthxuJUIRuKS2QcwtNKDiIBmCqrK aovvuXMk203/XuIFILRXUYvpbzKjTiQ4BzRl76Omk240Hryz5FapAGvqkwmrPzj4sdxu ycBzc9jjRktluRtyYs7j2UDh4rhsoqTwdhLg18MF/shVbKt+aYPf6idFWWz2vILS9HAs s0XQ== X-Gm-Message-State: ABuFfoiDPcwsTTgYO5tnr0U99qALzrc6F/kOfZLamkEKuaYUwYbguqcC OFKbHCkV+EfhBilN9mM6wW1wI90X X-Google-Smtp-Source: ACcGV60g2VNCrURu2nbkPRuCDMxVxhDve8K4tJnzCctBANlPcsItMBPuqQllgpqxpQGgDwFAKidexQ== X-Received: by 2002:a63:f941:: with SMTP id q1-v6mr11670940pgk.213.1538083906567; Thu, 27 Sep 2018 14:31:46 -0700 (PDT) Received: from kern417.eng.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id y86-v6sm5233285pfk.84.2018.09.27.14.31.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 27 Sep 2018 14:31:46 -0700 (PDT) From: Yifeng Sun To: dev@openvswitch.org Date: Thu, 27 Sep 2018 14:31:40 -0700 Message-Id: <1538083900-22428-1-git-send-email-pkusunyifeng@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] ovsdb-client: Fix a bug that uses wrong index X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org This patch fixes the incorrect index to argv. Signed-off-by: Yifeng Sun --- ovsdb/ovsdb-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index ab3aa7c93307..7c8a59d0e749 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -1761,9 +1761,9 @@ do_dump(struct jsonrpc *rpc, const char *database, for (i = 1; i < argc; i++) { node = shash_find(&tschema->columns, argv[i]); if (!node) { - ovs_fatal(0, "Table \"%s\" has no column %s.", argv[0], argv[1]); + ovs_fatal(0, "Table \"%s\" has no column %s.", argv[0], argv[i]); } - shash_add(&custom_columns, argv[1], node->data); + shash_add(&custom_columns, argv[i], node->data); } } else { tables = shash_sort(&schema->tables);