diff mbox series

[ovs-dev,2/4] ofp-actions: Fix dead assignment.

Message ID 1509384475-27951-3-git-send-email-u9012063@gmail.com
State Accepted
Headers show
Series Fix clang static checker errors. | expand

Commit Message

William Tu Oct. 30, 2017, 5:27 p.m. UTC
Clang reports value stored to 'eah' in never read.
Fix it by removing it.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 lib/ofp-actions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff Oct. 30, 2017, 7:45 p.m. UTC | #1
On Mon, Oct 30, 2017 at 10:27:53AM -0700, William Tu wrote:
> Clang reports value stored to 'eah' in never read.
> Fix it by removing it.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>

Thanks a lot!  Applied to master.
diff mbox series

Patch

diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 71eb70c3c239..79041c281ed0 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -5535,7 +5535,7 @@  encode_CLONE(const struct ofpact_nest *clone,
     const size_t ofs = out->size;
     struct ext_action_header *eah;
 
-    eah = put_NXAST_CLONE(out);
+    put_NXAST_CLONE(out);
     len = ofpacts_put_openflow_actions(clone->actions,
                                        ofpact_nest_get_action_len(clone),
                                        out, ofp_version);