diff mbox series

[ovs-dev,3/4] ovn-sbctl: Fix dead assignment.

Message ID 1509384475-27951-4-git-send-email-u9012063@gmail.com
State Accepted
Headers show
Series Fix clang static checker errors. | expand

Commit Message

William Tu Oct. 30, 2017, 5:27 p.m. UTC
Clang reports value stored to 'sb' is never read.
Fix it by removing it.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 ovn/utilities/ovn-sbctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff Oct. 30, 2017, 7:47 p.m. UTC | #1
On Mon, Oct 30, 2017 at 10:27:54AM -0700, William Tu wrote:
> Clang reports value stored to 'sb' is never read.
> Fix it by removing it.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>

Thanks, applied to master.
diff mbox series

Patch

diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c
index 7af5863b08fc..c5ec4e6eaf24 100644
--- a/ovn/utilities/ovn-sbctl.c
+++ b/ovn/utilities/ovn-sbctl.c
@@ -1235,7 +1235,7 @@  do_sbctl(const char *args, struct ctl_command *commands, size_t n_commands,
     const struct sbrec_sb_global *sb = sbrec_sb_global_first(idl);
     if (!sb) {
         /* XXX add verification that table is empty */
-        sb = sbrec_sb_global_insert(txn);
+        sbrec_sb_global_insert(txn);
     }
 
     symtab = ovsdb_symbol_table_create();