diff mbox

[ovs-dev,2/2] atlocal: Document find_l7_lib()

Message ID 1503449550-14262-2-git-send-email-yihung.wei@gmail.com
State Accepted
Headers show

Commit Message

Yi-Hung Wei Aug. 23, 2017, 12:52 a.m. UTC 
When a system traffic is skipped due to 'HAVE_FTP = no' or
'HAVE_TFTP = no', it takes some effort to figure out it is due to
missing the required python library. Add some comments around the
find_l7_lib(), so that user can figure that out by
$ git grep HAVE_FTP.

Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
---
 tests/atlocal.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Joe Stringer Aug. 23, 2017, 11:28 p.m. UTC | #1 
On 22 August 2017 at 17:52, Yi-Hung Wei <yihung.wei@gmail.com> wrote:
> When a system traffic is skipped due to 'HAVE_FTP = no' or
> 'HAVE_TFTP = no', it takes some effort to figure out it is due to
> missing the required python library. Add some comments around the
> find_l7_lib(), so that user can figure that out by
> $ git grep HAVE_FTP.
>
> Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
> ---

Thanks, applied to master.
diff mbox

Patch

diff --git a/tests/atlocal.in b/tests/atlocal.in
index 7c5e9e3357e5..95f98f4dc845 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -114,6 +114,8 @@  else
     HAVE_IPV6=no
 fi
 
+# Look for a python L7 library 'LIB' in the system. If it is found, defines
+# HAVE_LIB="yes", otherwise HAVE_LIB="no"
 find_l7_lib()
 {
     set +x
@@ -130,7 +132,9 @@  find_l7_lib()
     fi
 }
 
+# HAVE_FTP
 find_l7_lib ftp
+# HAVE_TFTP
 find_l7_lib tftp
 
 # Look for a commnand in the system. If it is found, defines