From patchwork Wed Aug 23 00:52:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi-Hung Wei X-Patchwork-Id: 804718 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="u7l8c4Xy"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xcTS07480z9s8P for ; Wed, 23 Aug 2017 10:53:04 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 12032A73; Wed, 23 Aug 2017 00:52:41 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 92DC0982 for ; Wed, 23 Aug 2017 00:52:39 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8817E193 for ; Wed, 23 Aug 2017 00:52:39 +0000 (UTC) Received: by mail-pg0-f65.google.com with SMTP id t3so263099pgt.5 for ; Tue, 22 Aug 2017 17:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ylkmFPG5bce0VjYp8BN0VmsQpVzS2NOcfymaych3aPY=; b=u7l8c4Xy3jEH/wVSZLljQ3n5avyA3h+38uMeNj+oAHpoulNVxCKkndAQzFM2zLB1M4 PXbCIYZMl5ICgFKq9g2Vgjg/BaWlbTdHOr6QkI5fqzilDRfy3ddzhtnNxPgusf9L4Mw+ kUf93anev42hvxSsWxsYWsjaA7HQJ0W/vVVf8BuoG3zMZbujoOXczDNdjh7UTQJ/lmLW v3vwdeWWAQRITcZsUW3OQHIpA2ulo5CMETnM4mtTR87f3M/3Q79Xv2XowDWNtIZ5nM72 kQar/iQqKjydMUds3p1h2606/S7oZTk+XkAC6gn4KZo7+BZnnoS7AKZrQRVnITbw6qtl OeIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ylkmFPG5bce0VjYp8BN0VmsQpVzS2NOcfymaych3aPY=; b=L5pBSzHYSBgWV9+wjSGgUqjrpWIzVSumWjaZKHWoLjqyPsFs+HPoo1OR4NXOwnN/dT OuapqR9AZMIxdExrzumm18W2Zc7RDKo6NwLQxU8GJfKxUPLi7PVFKldGqTwrBKvvNrsL k3HjxrXd5v29S8kkQsatDoy/KQ1jnss5ovQT7gaKCTqbM1xKUvPdgcLl+BaL0LYSshSK FlSrI7baYywHFGysOmJNja6sFtU6DvnH3doNvBNN0AzaEVkmQzcfS/BUpaER4GUdp9XY RefqWprSWBrlf+VyUqXiKaaIDpuTT0j0l/CA1KYSwcfISms3WU2xavdGvjDr4d0Vdgyb 9mfw== X-Gm-Message-State: AHYfb5iLJAQHuv5u0P+/I7SCS+HkY3oAJ6u1v3t//N1e4qA9ykkEBrU3 K7kkgqDcC2JUlUeSIHg= X-Received: by 10.98.160.65 with SMTP id r62mr965383pfe.65.1503449559007; Tue, 22 Aug 2017 17:52:39 -0700 (PDT) Received: from sc9-mailhost3.vmware.com ([208.91.2.1]) by smtp.gmail.com with ESMTPSA id q133sm283347pfq.31.2017.08.22.17.52.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Aug 2017 17:52:38 -0700 (PDT) From: Yi-Hung Wei To: dev@openvswitch.org Date: Tue, 22 Aug 2017 17:52:30 -0700 Message-Id: <1503449550-14262-2-git-send-email-yihung.wei@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503449550-14262-1-git-send-email-yihung.wei@gmail.com> References: <1503449550-14262-1-git-send-email-yihung.wei@gmail.com> Subject: [ovs-dev] [PATCH 2/2] atlocal: Document find_l7_lib() X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org When a system traffic is skipped due to 'HAVE_FTP = no' or 'HAVE_TFTP = no', it takes some effort to figure out it is due to missing the required python library. Add some comments around the find_l7_lib(), so that user can figure that out by $ git grep HAVE_FTP. Signed-off-by: Yi-Hung Wei --- tests/atlocal.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/atlocal.in b/tests/atlocal.in index 7c5e9e3357e5..95f98f4dc845 100644 --- a/tests/atlocal.in +++ b/tests/atlocal.in @@ -114,6 +114,8 @@ else HAVE_IPV6=no fi +# Look for a python L7 library 'LIB' in the system. If it is found, defines +# HAVE_LIB="yes", otherwise HAVE_LIB="no" find_l7_lib() { set +x @@ -130,7 +132,9 @@ find_l7_lib() fi } +# HAVE_FTP find_l7_lib ftp +# HAVE_TFTP find_l7_lib tftp # Look for a commnand in the system. If it is found, defines