| Message ID | 1469589897-42705-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Jul 26, 2016 at 08:24:57PM -0700, William Tu wrote: > Testcase 1857: ovsdb-monitor.at:538 monitor-cond-change reports the > following definitely memory leak: > ovsdb_schema_create (ovsdb.c:34) > ovsdb_schema_from_json (ovsdb.c:196) > fetch_schema (ovsdb-client.c:385) > do_monitor_cond (ovsdb-client.c:1112) This is the kind of pseudo-leak that doesn't matter because the program exists immediately. But we might as well fix it. > Signed-of-by: William Tu <u9012063@gmail.com> I corrected the spelling of Signed-"off"-by here. Thanks, I applied this to master.
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index 7dcc07c..1f83f3b 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -1120,6 +1120,7 @@ do_monitor_cond(struct jsonrpc *rpc, const char *database, NULL, &cnd)); ovsdb_condition_destroy(&cnd); do_monitor__(rpc, database, OVSDB_MONITOR_V2, --argc, ++argv, condition); + ovsdb_schema_destroy(schema); } struct dump_table_aux {
Testcase 1857: ovsdb-monitor.at:538 monitor-cond-change reports the following definitely memory leak: ovsdb_schema_create (ovsdb.c:34) ovsdb_schema_from_json (ovsdb.c:196) fetch_schema (ovsdb-client.c:385) do_monitor_cond (ovsdb-client.c:1112) Signed-of-by: William Tu <u9012063@gmail.com> --- ovsdb/ovsdb-client.c | 1 + 1 file changed, 1 insertion(+)