From patchwork Wed Jul 27 03:24:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 653064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rzgND542qz9srY for ; Wed, 27 Jul 2016 13:25:00 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=gnwjkL8K; dkim-atps=neutral Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id EB8EE10E29; Tue, 26 Jul 2016 20:24:59 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 1E55B10AEC for ; Tue, 26 Jul 2016 20:24:59 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id A1501161E1C for ; Tue, 26 Jul 2016 21:24:58 -0600 (MDT) X-ASG-Debug-ID: 1469589898-0b32374772854a0001-byXFYA Received: from mx3-pf2.cudamail.com ([192.168.14.1]) by bar6.cudamail.com with ESMTP id rTziIPOyKzFmLGLm (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 26 Jul 2016 21:24:58 -0600 (MDT) X-Barracuda-Envelope-From: u9012063@gmail.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.1 Received: from unknown (HELO mail-pa0-f67.google.com) (209.85.220.67) by mx3-pf2.cudamail.com with ESMTPS (AES128-SHA encrypted); 27 Jul 2016 03:24:57 -0000 Received-SPF: pass (mx3-pf2.cudamail.com: SPF record at _netblocks.google.com designates 209.85.220.67 as permitted sender) X-Barracuda-Apparent-Source-IP: 209.85.220.67 X-Barracuda-RBL-IP: 209.85.220.67 Received: by mail-pa0-f67.google.com with SMTP id hh10so946791pac.1 for ; Tue, 26 Jul 2016 20:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=XKWK796oz+roR24i2fwXbp6OQ9a/Dj9uGOHmSYjA45Q=; b=gnwjkL8KRsW9JSVLVh2RLOSBBghu9Jfny5NgYOP9UmTKTGq0Y4YGsAyhLIz+PugH3A kn4BKHBacWCxWp1XGTCjRh6c8CWpEHvUKaZnHzrzP5p4BdGq2t+Yq1GG8OWvTICoGK8B Vw5NWNQnqhN1/ewm4bKLxRGXlrvghvJSso4rPfn84ot0XvmAgoxq5N2QVrJAg0Sr4iYJ UgkOMYwELTNgLMFdQG/2DNNiFkF+YG+2NumhbHAZxSD9gLBxeckNNNQzAycDgVbX99nt tWwmFqQZWGz+AbzDk30PXFdI/CGxHxBPRfNXIqG9KB4szk7dlckjGeYcvtGlkMxoanPa YopQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=XKWK796oz+roR24i2fwXbp6OQ9a/Dj9uGOHmSYjA45Q=; b=ZTaZS21akxqNXUITOWhAe5U22+6CzcTbd7tATSrYowAt5EoQUDBSkuPfws6agfCm1p 3XgVnWHOMQJnZbNMlAHTaJizCeEcHxX8zz1jbseafBeiYaTQ7sWJ1etjcZEwb1fqY4Zk xJK5x/H54sIKYWt9cRN3uG2cFsModubnFxf9lwYsqAePbIXp2s7hlUD3fzM0XKtZA50y jeE4PlAj278WWDa95pMBoVL6Mi1DuhiYUyAMSBsT+NDeGRTMOILRBDZf8f6FsnCFs0Fg DeuxGCjdmvyHznU1irtHbOLeYM5D56LjA3bruZuX46qw1ohOtWLRGH2eNYyTxQ6lQNGH 4oeQ== X-Gm-Message-State: AEkoouuaf/NuvZ6waswOdEYN6lZ9hfK8P8bszbYvRHboxhc8oh6iN2lo/Uw/blomtAeKCA== X-Received: by 10.66.254.39 with SMTP id af7mr45500246pad.37.1469589896948; Tue, 26 Jul 2016 20:24:56 -0700 (PDT) Received: from vm-dev.localdomain ([73.93.155.36]) by smtp.gmail.com with ESMTPSA id d72sm4630344pfj.15.2016.07.26.20.24.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jul 2016 20:24:56 -0700 (PDT) X-CudaMail-Envelope-Sender: u9012063@gmail.com From: William Tu To: dev@openvswitch.org X-CudaMail-MID: CM-V2-725062986 X-CudaMail-DTE: 072616 X-CudaMail-Originating-IP: 209.85.220.67 Date: Tue, 26 Jul 2016 20:24:57 -0700 X-ASG-Orig-Subj: [##CM-V2-725062986##][PATCH] ovsdb-client: Fix memory leak reported by Valgrind. Message-Id: <1469589897-42705-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.5.0 X-GBUdb-Analysis: 0, 209.85.220.67, Ugly c=0.387593 p=-0.162791 Source Normal X-MessageSniffer-Rules: 0-0-0-4346-c X-Barracuda-Connect: UNKNOWN[192.168.14.1] X-Barracuda-Start-Time: 1469589898 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 1.10 X-Barracuda-Spam-Status: No, SCORE=1.10 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC5_MJ1963, DKIM_SIGNED, MAILTO_TO_SPAM_ADDR, RDNS_NONE, WEIRD_PORT X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.31547 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.00 MAILTO_TO_SPAM_ADDR URI: Includes a link to a likely spammer email 0.50 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 Subject: [ovs-dev] [PATCH] ovsdb-client: Fix memory leak reported by Valgrind. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" Testcase 1857: ovsdb-monitor.at:538 monitor-cond-change reports the following definitely memory leak: ovsdb_schema_create (ovsdb.c:34) ovsdb_schema_from_json (ovsdb.c:196) fetch_schema (ovsdb-client.c:385) do_monitor_cond (ovsdb-client.c:1112) Signed-of-by: William Tu --- ovsdb/ovsdb-client.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index 7dcc07c..1f83f3b 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -1120,6 +1120,7 @@ do_monitor_cond(struct jsonrpc *rpc, const char *database, NULL, &cnd)); ovsdb_condition_destroy(&cnd); do_monitor__(rpc, database, OVSDB_MONITOR_V2, --argc, ++argv, condition); + ovsdb_schema_destroy(schema); } struct dump_table_aux {