mbox series

[ovs-dev,0/6] installer fixes on msbuild64

Message ID 20171031172537.2292-1-aserdean@ovn.org
Headers show
Series installer fixes on msbuild64 | expand

Message

Alin-Gabriel Serdean Oct. 31, 2017, 5:25 p.m. UTC 
Installer fixes to allow the MSI build using msbuild(64bit variant).

Alin Gabriel Serdean (6):
  build-windows: Suppress output from MSBuild
  installer-windows: Remove unused entries from WIX project
  installer-windows: Resolve WIX solution build type
  installer-windows: Call WIX binaries outside of MSBuild on x64
  installer-windows: Modify installer so it can be compiled on x64
  installer-windows: Add x64 installer build via command line

 Makefile.am                                        |  9 ++---
 datapath-windows/automake.mk                       |  4 +--
 m4/openvswitch.m4                                  |  3 ++
 windows/automake.mk                                |  2 +-
 windows/ovs-windows-installer.sln                  |  4 +--
 windows/ovs-windows-installer/Product.wxs          | 12 ++++++-
 .../ovs-windows-installer.wixproj                  | 42 +++-------------------
 7 files changed, 28 insertions(+), 48 deletions(-)

Comments

Ben Pfaff Oct. 31, 2017, 10:37 p.m. UTC | #1 
On Tue, Oct 31, 2017 at 07:25:31PM +0200, Alin Gabriel Serdean wrote:
> Installer fixes to allow the MSI build using msbuild(64bit variant).
> 
> Alin Gabriel Serdean (6):
>   build-windows: Suppress output from MSBuild
>   installer-windows: Remove unused entries from WIX project
>   installer-windows: Resolve WIX solution build type
>   installer-windows: Call WIX binaries outside of MSBuild on x64
>   installer-windows: Modify installer so it can be compiled on x64
>   installer-windows: Add x64 installer build via command line

All of these seem reasonable to me.  I don't fully understand a lot of
them but the commit messages make some sense to me.  Please feel free to
seek better reviews, if you like.
Alin-Gabriel Serdean Nov. 1, 2017, 10:04 p.m. UTC | #2 
> -----Original Message-----
> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-
> bounces@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Wednesday, November 1, 2017 12:37 AM
> To: Alin Gabriel Serdean <aserdean@ovn.org>
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 0/6] installer fixes on msbuild64
> 
> On Tue, Oct 31, 2017 at 07:25:31PM +0200, Alin Gabriel Serdean wrote:
> > Installer fixes to allow the MSI build using msbuild(64bit variant).
> >
> > Alin Gabriel Serdean (6):
> >   build-windows: Suppress output from MSBuild
> >   installer-windows: Remove unused entries from WIX project
> >   installer-windows: Resolve WIX solution build type
> >   installer-windows: Call WIX binaries outside of MSBuild on x64
> >   installer-windows: Modify installer so it can be compiled on x64
> >   installer-windows: Add x64 installer build via command line
> 
> All of these seem reasonable to me.  I don't fully understand a lot of
them
> but the commit messages make some sense to me.  Please feel free to seek
> better reviews, if you like.
Thanks for looking over patches.
I hope to get more reviews from the other windows devs (at least somebody
else to test it and double confirm it works).