| Message ID | 1577096053-20507-2-git-send-email-madalin.bucur@oss.nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | Add PHY connection types for XFI and SFI | expand |
On Mon, Dec 23, 2019 at 12:14:07PM +0200, Madalin Bucur wrote: > From: Madalin Bucur <madalin.bucur@nxp.com> > > Add explicit entries for XFI, SFI to make sure the device > tree entries for phy-connection-type "xfi" or "sfi" are > properly parsed and differentiated against the existing > backplane 10GBASE-KR mode. > > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> NAK until we've finished discussing this matter in the previous posting. > --- > include/linux/phy.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index dd4a91f1feaa..5651c7be0c45 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -99,7 +99,8 @@ typedef enum { > PHY_INTERFACE_MODE_2500BASEX, > PHY_INTERFACE_MODE_RXAUI, > PHY_INTERFACE_MODE_XAUI, > - /* 10GBASE-KR, XFI, SFI - single lane 10G Serdes */ > + PHY_INTERFACE_MODE_XFI, > + PHY_INTERFACE_MODE_SFI, > PHY_INTERFACE_MODE_10GKR, > PHY_INTERFACE_MODE_USXGMII, > PHY_INTERFACE_MODE_MAX, > @@ -175,6 +176,10 @@ static inline const char *phy_modes(phy_interface_t interface) > return "rxaui"; > case PHY_INTERFACE_MODE_XAUI: > return "xaui"; > + case PHY_INTERFACE_MODE_XFI: > + return "xfi"; > + case PHY_INTERFACE_MODE_SFI: > + return "sfi"; > case PHY_INTERFACE_MODE_10GKR: > return "10gbase-kr"; > case PHY_INTERFACE_MODE_USXGMII: > -- > 2.1.0 > >
On Mon, Dec 23, 2019 at 10:57:43AM +0000, Russell King - ARM Linux admin wrote: > On Mon, Dec 23, 2019 at 12:14:07PM +0200, Madalin Bucur wrote: > > From: Madalin Bucur <madalin.bucur@nxp.com> > > > > Add explicit entries for XFI, SFI to make sure the device > > tree entries for phy-connection-type "xfi" or "sfi" are > > properly parsed and differentiated against the existing > > backplane 10GBASE-KR mode. > > > > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > > NAK until we've finished discussing this matter in the previous posting. Agreed. Lets fully understand the issues before we start patching stuff. Andrew
diff --git a/include/linux/phy.h b/include/linux/phy.h index dd4a91f1feaa..5651c7be0c45 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -99,7 +99,8 @@ typedef enum { PHY_INTERFACE_MODE_2500BASEX, PHY_INTERFACE_MODE_RXAUI, PHY_INTERFACE_MODE_XAUI, - /* 10GBASE-KR, XFI, SFI - single lane 10G Serdes */ + PHY_INTERFACE_MODE_XFI, + PHY_INTERFACE_MODE_SFI, PHY_INTERFACE_MODE_10GKR, PHY_INTERFACE_MODE_USXGMII, PHY_INTERFACE_MODE_MAX, @@ -175,6 +176,10 @@ static inline const char *phy_modes(phy_interface_t interface) return "rxaui"; case PHY_INTERFACE_MODE_XAUI: return "xaui"; + case PHY_INTERFACE_MODE_XFI: + return "xfi"; + case PHY_INTERFACE_MODE_SFI: + return "sfi"; case PHY_INTERFACE_MODE_10GKR: return "10gbase-kr"; case PHY_INTERFACE_MODE_USXGMII: