mbox series

[net-next,0/2] net: phy: Add ability to debug RGMII connections

Message ID 20191015224953.24199-1-f.fainelli@gmail.com
Headers show
Series net: phy: Add ability to debug RGMII connections | expand

Message

Florian Fainelli Oct. 15, 2019, 10:49 p.m. UTC 
Hi all,

This patch series is primarily intended to reduce the amount of support
involved with bringing up RGMII connections with the PHY library (or
PHYLINK) for that matter. The idea consists in looping back a packet we
just crafted and check whether it did came back correctly, if that is
the case, we are good, else we must try configuring the PHY for
different delays until it either works or we bail out.

As indicated in the commit message, future improvements could probably
be done in order to converge faster on the appropriate configuration.
This is intended to be PHY centric, and we are not playing with delays
on the MAC side other than through the parsing of the phydev->interface.

The typical output would look like this:

[   62.668701] bcmgenet 8f00000.ethernet eth0: Trying "rgmii-txid" PHY interface
[   62.676094] bcmgenet 8f00000.ethernet eth0: Determined "rgmii-txid" to be correct

Feedback highly welcome on this!

Florian Fainelli (2):
  net: phy: Use genphy_loopback() by default
  net: phy: Add ability to debug RGMII connections

 .../ABI/testing/sysfs-class-net-phydev        |  11 +
 drivers/net/phy/Kconfig                       |   9 +
 drivers/net/phy/Makefile                      |   1 +
 drivers/net/phy/phy-rgmii-debug.c             | 269 ++++++++++++++++++
 drivers/net/phy/phy_device.c                  |  33 ++-
 include/linux/phy.h                           |   9 +
 6 files changed, 331 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/phy/phy-rgmii-debug.c

Comments

David Miller Oct. 17, 2019, 7:24 p.m. UTC | #1 
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 15 Oct 2019 15:49:51 -0700

> This patch series is primarily intended to reduce the amount of support
> involved with bringing up RGMII connections with the PHY library (or
> PHYLINK) for that matter. The idea consists in looping back a packet we
> just crafted and check whether it did came back correctly, if that is
> the case, we are good, else we must try configuring the PHY for
> different delays until it either works or we bail out.
> 
> As indicated in the commit message, future improvements could probably
> be done in order to converge faster on the appropriate configuration.
> This is intended to be PHY centric, and we are not playing with delays
> on the MAC side other than through the parsing of the phydev->interface.
> 
> The typical output would look like this:
> 
> [   62.668701] bcmgenet 8f00000.ethernet eth0: Trying "rgmii-txid" PHY interface
> [   62.676094] bcmgenet 8f00000.ethernet eth0: Determined "rgmii-txid" to be correct
> 
> Feedback highly welcome on this!

Looks like there was some feedback, please address.

Thank you.