| Message ID | 20191015224953.24199-2-f.fainelli@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: Add ability to debug RGMII connections | expand |
On Tue, Oct 15, 2019 at 03:49:52PM -0700, Florian Fainelli wrote: > The standard way of putting a PHY device into loopback is most often > suitable for testing. This is going to be necessary in a subsequent > patch that adds RGII debugging capability using the loopback feature. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/net/phy/phy_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 9d2bbb13293e..c2e66b9ec161 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -1514,7 +1514,7 @@ int phy_loopback(struct phy_device *phydev, bool enable) > if (phydev->drv && phydrv->set_loopback) > ret = phydrv->set_loopback(phydev, enable); > else > - ret = -EOPNOTSUPP; > + ret = genphy_loopback(phydev, enable); Hi Florian I think you need to differentiate between C22 and C45 somewhere. Andrew
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 9d2bbb13293e..c2e66b9ec161 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1514,7 +1514,7 @@ int phy_loopback(struct phy_device *phydev, bool enable) if (phydev->drv && phydrv->set_loopback) ret = phydrv->set_loopback(phydev, enable); else - ret = -EOPNOTSUPP; + ret = genphy_loopback(phydev, enable); if (ret) goto out;
The standard way of putting a PHY device into loopback is most often suitable for testing. This is going to be necessary in a subsequent patch that adds RGII debugging capability using the loopback feature. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)