| Message ID | 20211217165919.2700920-4-thierry.reding@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/5] dt-bindings: memory: Document Tegra210 EMC table | expand |
On Fri, 17 Dec 2021 17:59:18 +0100, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > While the memory controller found on Tegra132 is largely compatible with > the one found on Tegra124, there are some differences that may require > more specific matching on a Tegra132 compatible string, so add one to > the list of compatible strings. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > .../bindings/memory-controllers/nvidia,tegra124-emc.yaml | 6 +++++- > .../bindings/memory-controllers/nvidia,tegra124-mc.yaml | 4 +++- > 2 files changed, 8 insertions(+), 2 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1570204 external-memory-controller@7001b000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/nvidia/tegra132-norrin.dt.yaml external-memory-controller@7001b000: '#interconnect-cells' is a required property arch/arm64/boot/dts/nvidia/tegra132-norrin.dt.yaml external-memory-controller@7001b000: 'operating-points-v2' is a required property arch/arm64/boot/dts/nvidia/tegra132-norrin.dt.yaml memory-controller@70019000: '#interconnect-cells' is a required property arch/arm64/boot/dts/nvidia/tegra132-norrin.dt.yaml memory-controller@70019000: '#reset-cells' is a required property arch/arm64/boot/dts/nvidia/tegra132-norrin.dt.yaml
On Fri, 17 Dec 2021 17:59:18 +0100, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > While the memory controller found on Tegra132 is largely compatible with > the one found on Tegra124, there are some differences that may require > more specific matching on a Tegra132 compatible string, so add one to > the list of compatible strings. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > .../bindings/memory-controllers/nvidia,tegra124-emc.yaml | 6 +++++- > .../bindings/memory-controllers/nvidia,tegra124-mc.yaml | 4 +++- > 2 files changed, 8 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml index 9163c3f12a85..90666e8d2de7 100644 --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml @@ -16,7 +16,11 @@ description: | properties: compatible: - const: nvidia,tegra124-emc + oneOf: + - const: nvidia,tegra124-emc + - items: + - const: nvidia,tegra132-emc + - const: nvidia,tegra124-emc reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml index 7b18b4d11e0a..887917e02bfa 100644 --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml @@ -19,7 +19,9 @@ description: | properties: compatible: - const: nvidia,tegra124-mc + enum: + - nvidia,tegra124-mc + - nvidia,tegra132-mc reg: maxItems: 1