diff mbox series

[linux,v6,3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

Message ID 20240202001733.91455-4-dharma.b@microchip.com
State Handled Elsewhere
Headers show
Series Convert Microchip's HLCDC Text based DT bindings to JSON schema | expand

Commit Message

Dharma Balasubiramani Feb. 2, 2024, 12:17 a.m. UTC
Convert the atmel,hlcdc binding to DT schema format.

Align clocks and clock-names properties to clearly indicate that the LCD
controller expects lvds_pll_clk when interfaced with the lvds display. This
alignment with the specific hardware requirements ensures accurate device tree
configuration for systems utilizing the HLCDC IP.

Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
Changelog
v5 -> v6
- No changes.
v4 -> v5
- Revert v3 dropping lvds_pll_clk instead add it as an optional clock.
- Update minItems to 3.
- Update commit message accordingly.
v3 -> v4
- Drop lvds_pll_clk, It can be enabled in lvds driver itself.
- Update commit message.
Note: Since there is no complexities now, I believe that specifying
maxitems in the clocks property should be sufficient.
v2 -> v3
- Rename hlcdc-display-controller and hlcdc-pwm to generic names.
- Modify the description by removing the unwanted comments and '|'.
- Modify clock-names simpler.
v1 -> v2
- Remove the explicit copyrights.
- Modify title (not include words like binding/driver).
- Modify description actually describing the hardware and not the driver.
- Add details of lvds_pll addition in commit message.
- Ref endpoint and not endpoint-base.
- Fix coding style.
...
 .../devicetree/bindings/mfd/atmel,hlcdc.yaml  | 99 +++++++++++++++++++
 .../devicetree/bindings/mfd/atmel-hlcdc.txt   | 56 -----------
 2 files changed, 99 insertions(+), 56 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt

Comments

Lee Jones Feb. 8, 2024, 10:43 a.m. UTC | #1
On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
> Convert the atmel,hlcdc binding to DT schema format.
> 
> Align clocks and clock-names properties to clearly indicate that the LCD
> controller expects lvds_pll_clk when interfaced with the lvds display. This
> alignment with the specific hardware requirements ensures accurate device tree
> configuration for systems utilizing the HLCDC IP.
> 
> [...]

Applied, thanks!

[3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
      commit: cb946db1335b599ece363d33966bf653ed0fa58a

--
Lee Jones [李琼斯]
Krzysztof Kozlowski Feb. 12, 2024, 10:23 a.m. UTC | #2
On 08/02/2024 11:43, Lee Jones wrote:
> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
>> Convert the atmel,hlcdc binding to DT schema format.
>>
>> Align clocks and clock-names properties to clearly indicate that the LCD
>> controller expects lvds_pll_clk when interfaced with the lvds display. This
>> alignment with the specific hardware requirements ensures accurate device tree
>> configuration for systems utilizing the HLCDC IP.
>>
>> [...]
> 
> Applied, thanks!
> 
> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
>       commit: cb946db1335b599ece363d33966bf653ed0fa58a
> 

Next is still failing.

Dharma,
You must explain and clearly mark dependencies between patches.

Lee,
Can you pick up two previous patches as well?

Best regards,
Krzysztof
Uwe Kleine-König Feb. 15, 2024, 10:02 a.m. UTC | #3
On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote:
> On 08/02/2024 11:43, Lee Jones wrote:
> > On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
> >> Convert the atmel,hlcdc binding to DT schema format.
> >>
> >> Align clocks and clock-names properties to clearly indicate that the LCD
> >> controller expects lvds_pll_clk when interfaced with the lvds display. This
> >> alignment with the specific hardware requirements ensures accurate device tree
> >> configuration for systems utilizing the HLCDC IP.
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> > [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
> >       commit: cb946db1335b599ece363d33966bf653ed0fa58a
> > 
> 
> Next is still failing.

Failing in the sense of dtbs_check, right?

> Dharma,
> You must explain and clearly mark dependencies between patches.
> 
> Lee,
> Can you pick up two previous patches as well?

I applied the pwm patch now. If Lee wants to pick up this one via his
tree that would be fine for me, too. If that's the case please tell me,
then I'll drop it from my for-next branch again. Feel free to add
my Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patch
#2 then.

Best regards
Uwe
Krzysztof Kozlowski Feb. 15, 2024, 6:44 p.m. UTC | #4
On 15/02/2024 11:02, Uwe Kleine-König wrote:
> On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote:
>> On 08/02/2024 11:43, Lee Jones wrote:
>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
>>>> Convert the atmel,hlcdc binding to DT schema format.
>>>>
>>>> Align clocks and clock-names properties to clearly indicate that the LCD
>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This
>>>> alignment with the specific hardware requirements ensures accurate device tree
>>>> configuration for systems utilizing the HLCDC IP.
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
>>>       commit: cb946db1335b599ece363d33966bf653ed0fa58a
>>>
>>
>> Next is still failing.
> 
> Failing in the sense of dtbs_check, right?

No, bindings were failing. dt_binding_check. This must not fail, so kind
of bummer...


> 
>> Dharma,
>> You must explain and clearly mark dependencies between patches.
>>
>> Lee,
>> Can you pick up two previous patches as well?
> 
> I applied the pwm patch now. If Lee wants to pick up this one via his
> tree that would be fine for me, too. If that's the case please tell me,
> then I'll drop it from my for-next branch again. Feel free to add
> my Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patch
> #2 then.

At least next is happy.
> 

Best regards,
Krzysztof
Uwe Kleine-König Feb. 16, 2024, 8:43 a.m. UTC | #5
Hello Krzysztof,

On Thu, Feb 15, 2024 at 07:44:53PM +0100, Krzysztof Kozlowski wrote:
> On 15/02/2024 11:02, Uwe Kleine-König wrote:
> > On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote:
> >> On 08/02/2024 11:43, Lee Jones wrote:
> >>> Applied, thanks!
> >>>
> >>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
> >>>       commit: cb946db1335b599ece363d33966bf653ed0fa58a
> >>>
> >>
> >> Next is still failing.
> > 
> > Failing in the sense of dtbs_check, right?
> 
> No, bindings were failing. dt_binding_check. This must not fail, so kind
> of bummer...
> 
> >> Dharma,
> >> You must explain and clearly mark dependencies between patches.
> >>
> >> Lee,
> >> Can you pick up two previous patches as well?
> > 
> > I applied the pwm patch now. If Lee wants to pick up this one via his
> > tree that would be fine for me, too. If that's the case please tell me,
> > then I'll drop it from my for-next branch again. Feel free to add
> > my Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patch
> > #2 then.
> 
> At least next is happy.

The pwm binding is in next now (as
0fa319a1427f7c8d0af4c255316624f7e6f649a0) but dt_binding_check still
tells me (among others):

	Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml:
	Error in referenced schema matching $id: http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml

This is what you meant, right? This goes away as soon as the first patch
(dt-bindings: display: convert Atmel's HLCDC to DT schema) is applied,
too. So next isn't completely happy yet.

Best regards
Uwe
Krzysztof Kozlowski Feb. 16, 2024, 10:04 a.m. UTC | #6
On 16/02/2024 09:43, Uwe Kleine-König wrote:
>>> I applied the pwm patch now. If Lee wants to pick up this one via his
>>> tree that would be fine for me, too. If that's the case please tell me,
>>> then I'll drop it from my for-next branch again. Feel free to add
>>> my Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patch
>>> #2 then.
>>
>> At least next is happy.
> 
> The pwm binding is in next now (as
> 0fa319a1427f7c8d0af4c255316624f7e6f649a0) but dt_binding_check still
> tells me (among others):
> 
> 	Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml:
> 	Error in referenced schema matching $id: http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml
> 
> This is what you meant, right? This goes away as soon as the first patch

Yeah, apparently there was more than one dependency.

> (dt-bindings: display: convert Atmel's HLCDC to DT schema) is applied,
> too. So next isn't completely happy yet.

Sigh...

Best regards,
Krzysztof
Dharma Balasubiramani Feb. 20, 2024, 3:34 a.m. UTC | #7
Hi Krzysztof,

On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 08/02/2024 11:43, Lee Jones wrote:
>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
>>> Convert the atmel,hlcdc binding to DT schema format.
>>>
>>> Align clocks and clock-names properties to clearly indicate that the LCD
>>> controller expects lvds_pll_clk when interfaced with the lvds display. This
>>> alignment with the specific hardware requirements ensures accurate device tree
>>> configuration for systems utilizing the HLCDC IP.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
>>        commit: cb946db1335b599ece363d33966bf653ed0fa58a
>>
> 
> Next is still failing.
> 
> Dharma,
> You must explain and clearly mark dependencies between patches.

I sincerely apologize for any confusion caused by the oversight. I have 
organized the patches according to their dependencies in the patch 
series, but unfortunately, I neglected to explicitly mention these 
dependencies. I understand the importance of clear communication in our 
collaborative efforts. Please feel free to provide guidance on how I can 
assist you further in resolving this matter.

> 
> Lee,
> Can you pick up two previous patches as well?
> 
> Best regards,
> Krzysztof
>
Lee Jones Feb. 20, 2024, 8:20 a.m. UTC | #8
On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote:

> Hi Krzysztof,
> 
> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On 08/02/2024 11:43, Lee Jones wrote:
> >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
> >>> Convert the atmel,hlcdc binding to DT schema format.
> >>>
> >>> Align clocks and clock-names properties to clearly indicate that the LCD
> >>> controller expects lvds_pll_clk when interfaced with the lvds display. This
> >>> alignment with the specific hardware requirements ensures accurate device tree
> >>> configuration for systems utilizing the HLCDC IP.
> >>>
> >>> [...]
> >>
> >> Applied, thanks!
> >>
> >> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
> >>        commit: cb946db1335b599ece363d33966bf653ed0fa58a
> >>
> > 
> > Next is still failing.
> > 
> > Dharma,
> > You must explain and clearly mark dependencies between patches.
> 
> I sincerely apologize for any confusion caused by the oversight. I have 
> organized the patches according to their dependencies in the patch 
> series, but unfortunately, I neglected to explicitly mention these 
> dependencies. I understand the importance of clear communication in our 
> collaborative efforts. Please feel free to provide guidance on how I can 
> assist you further in resolving this matter.

If this continues to be an issue, I can just remove the commit.
Dharma Balasubiramani Feb. 20, 2024, 8:30 a.m. UTC | #9
Hi Lee,

On 20/02/24 1:50 pm, Lee Jones wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote:
> 
>> Hi Krzysztof,
>>
>> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> On 08/02/2024 11:43, Lee Jones wrote:
>>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
>>>>> Convert the atmel,hlcdc binding to DT schema format.
>>>>>
>>>>> Align clocks and clock-names properties to clearly indicate that the LCD
>>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This
>>>>> alignment with the specific hardware requirements ensures accurate device tree
>>>>> configuration for systems utilizing the HLCDC IP.
>>>>>
>>>>> [...]
>>>>
>>>> Applied, thanks!
>>>>
>>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
>>>>         commit: cb946db1335b599ece363d33966bf653ed0fa58a
>>>>
>>>
>>> Next is still failing.
>>>
>>> Dharma,
>>> You must explain and clearly mark dependencies between patches.
>>
>> I sincerely apologize for any confusion caused by the oversight. I have
>> organized the patches according to their dependencies in the patch
>> series, but unfortunately, I neglected to explicitly mention these
>> dependencies. I understand the importance of clear communication in our
>> collaborative efforts. Please feel free to provide guidance on how I can
>> assist you further in resolving this matter.
> 
> If this continues to be an issue, I can just remove the commit.

There won't be any issue if both pwm and display binding goes before the 
mfd binding.

Could you please pick the display binding as well?

> 
> --
> Lee Jones [李琼斯]
Uwe Kleine-König Feb. 20, 2024, 8:39 a.m. UTC | #10
Hello,

On Tue, Feb 20, 2024 at 08:20:26AM +0000, Lee Jones wrote:
> On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote:
> > On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
> > > On 08/02/2024 11:43, Lee Jones wrote:
> > >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
> > >>> Convert the atmel,hlcdc binding to DT schema format.
> > >>>
> > >>> Align clocks and clock-names properties to clearly indicate that the LCD
> > >>> controller expects lvds_pll_clk when interfaced with the lvds display. This
> > >>> alignment with the specific hardware requirements ensures accurate device tree
> > >>> configuration for systems utilizing the HLCDC IP.
> > >>>
> > >>> [...]
> > >>
> > >> Applied, thanks!
> > >>
> > >> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
> > >>        commit: cb946db1335b599ece363d33966bf653ed0fa58a
> > >>
> > > 
> > > Next is still failing.
>
> If this continues to be an issue, I can just remove the commit.

The missing part in next is that patch 1 isn't included. So the options
are:

 a) Someone (dri or dt folks?) merges patch 1
    This fixes the state in next, though some commits stay around that
    fail dt_binding_check

 b) Someone (mfd or dt?) merges all 3 patches in one go and the two
    patches already applied are dropped.
    This makes dt_binding_check happy for all revs.

For me a) is good enough, but I guess the dri people are not aware there
is something to do for them?! Would be nice if Sam or Boris commented.

Best regards
Uwe
Krzysztof Kozlowski Feb. 20, 2024, 8:43 a.m. UTC | #11
On 20/02/2024 04:34, Dharma.B@microchip.com wrote:
> Hi Krzysztof,
> 
> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 08/02/2024 11:43, Lee Jones wrote:
>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
>>>> Convert the atmel,hlcdc binding to DT schema format.
>>>>
>>>> Align clocks and clock-names properties to clearly indicate that the LCD
>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This
>>>> alignment with the specific hardware requirements ensures accurate device tree
>>>> configuration for systems utilizing the HLCDC IP.
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
>>>        commit: cb946db1335b599ece363d33966bf653ed0fa58a
>>>
>>
>> Next is still failing.
>>
>> Dharma,
>> You must explain and clearly mark dependencies between patches.
> 
> I sincerely apologize for any confusion caused by the oversight. I have 
> organized the patches according to their dependencies in the patch 

Does it mean that all your other patchsets which contain multiple
patches have dependencies? That would be the meaning of above approach.
Unfortunately that's not good... I'll comment in other places for
individual issues.

Best regards,
Krzysztof
Rob Herring (Arm) Feb. 22, 2024, 11:21 p.m. UTC | #12
On Tue, Feb 20, 2024 at 08:30:38AM +0000, Dharma.B@microchip.com wrote:
> Hi Lee,
> 
> On 20/02/24 1:50 pm, Lee Jones wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote:
> > 
> >> Hi Krzysztof,
> >>
> >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
> >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >>>
> >>> On 08/02/2024 11:43, Lee Jones wrote:
> >>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
> >>>>> Convert the atmel,hlcdc binding to DT schema format.
> >>>>>
> >>>>> Align clocks and clock-names properties to clearly indicate that the LCD
> >>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This
> >>>>> alignment with the specific hardware requirements ensures accurate device tree
> >>>>> configuration for systems utilizing the HLCDC IP.
> >>>>>
> >>>>> [...]
> >>>>
> >>>> Applied, thanks!
> >>>>
> >>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
> >>>>         commit: cb946db1335b599ece363d33966bf653ed0fa58a
> >>>>
> >>>
> >>> Next is still failing.
> >>>
> >>> Dharma,
> >>> You must explain and clearly mark dependencies between patches.
> >>
> >> I sincerely apologize for any confusion caused by the oversight. I have
> >> organized the patches according to their dependencies in the patch
> >> series, but unfortunately, I neglected to explicitly mention these
> >> dependencies. I understand the importance of clear communication in our
> >> collaborative efforts. Please feel free to provide guidance on how I can
> >> assist you further in resolving this matter.
> > 
> > If this continues to be an issue, I can just remove the commit.
> 
> There won't be any issue if both pwm and display binding goes before the 
> mfd binding.
> 
> Could you please pick the display binding as well?

As this is still not resolved, I've applied the display binding. Not 
ideal, but should fix next.

Rob
Lee Jones Feb. 23, 2024, 10:23 a.m. UTC | #13
On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote:

> Hi Lee,
> 
> On 20/02/24 1:50 pm, Lee Jones wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote:
> > 
> >> Hi Krzysztof,
> >>
> >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
> >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >>>
> >>> On 08/02/2024 11:43, Lee Jones wrote:
> >>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
> >>>>> Convert the atmel,hlcdc binding to DT schema format.
> >>>>>
> >>>>> Align clocks and clock-names properties to clearly indicate that the LCD
> >>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This
> >>>>> alignment with the specific hardware requirements ensures accurate device tree
> >>>>> configuration for systems utilizing the HLCDC IP.
> >>>>>
> >>>>> [...]
> >>>>
> >>>> Applied, thanks!
> >>>>
> >>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
> >>>>         commit: cb946db1335b599ece363d33966bf653ed0fa58a
> >>>>
> >>>
> >>> Next is still failing.
> >>>
> >>> Dharma,
> >>> You must explain and clearly mark dependencies between patches.
> >>
> >> I sincerely apologize for any confusion caused by the oversight. I have
> >> organized the patches according to their dependencies in the patch
> >> series, but unfortunately, I neglected to explicitly mention these
> >> dependencies. I understand the importance of clear communication in our
> >> collaborative efforts. Please feel free to provide guidance on how I can
> >> assist you further in resolving this matter.
> > 
> > If this continues to be an issue, I can just remove the commit.
> 
> There won't be any issue if both pwm and display binding goes before the 
> mfd binding.
> 
> Could you please pick the display binding as well?

Only with an ACK from the relevant Maintainers.
Lee Jones Feb. 23, 2024, 10:25 a.m. UTC | #14
On Thu, 22 Feb 2024, Rob Herring wrote:

> On Tue, Feb 20, 2024 at 08:30:38AM +0000, Dharma.B@microchip.com wrote:
> > Hi Lee,
> > 
> > On 20/02/24 1:50 pm, Lee Jones wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > > 
> > > On Tue, 20 Feb 2024, Dharma.B@microchip.com wrote:
> > > 
> > >> Hi Krzysztof,
> > >>
> > >> On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote:
> > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > >>>
> > >>> On 08/02/2024 11:43, Lee Jones wrote:
> > >>>> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote:
> > >>>>> Convert the atmel,hlcdc binding to DT schema format.
> > >>>>>
> > >>>>> Align clocks and clock-names properties to clearly indicate that the LCD
> > >>>>> controller expects lvds_pll_clk when interfaced with the lvds display. This
> > >>>>> alignment with the specific hardware requirements ensures accurate device tree
> > >>>>> configuration for systems utilizing the HLCDC IP.
> > >>>>>
> > >>>>> [...]
> > >>>>
> > >>>> Applied, thanks!
> > >>>>
> > >>>> [3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format
> > >>>>         commit: cb946db1335b599ece363d33966bf653ed0fa58a
> > >>>>
> > >>>
> > >>> Next is still failing.
> > >>>
> > >>> Dharma,
> > >>> You must explain and clearly mark dependencies between patches.
> > >>
> > >> I sincerely apologize for any confusion caused by the oversight. I have
> > >> organized the patches according to their dependencies in the patch
> > >> series, but unfortunately, I neglected to explicitly mention these
> > >> dependencies. I understand the importance of clear communication in our
> > >> collaborative efforts. Please feel free to provide guidance on how I can
> > >> assist you further in resolving this matter.
> > > 
> > > If this continues to be an issue, I can just remove the commit.
> > 
> > There won't be any issue if both pwm and display binding goes before the 
> > mfd binding.
> > 
> > Could you please pick the display binding as well?
> 
> As this is still not resolved, I've applied the display binding. Not 
> ideal, but should fix next.

Works for me.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml b/Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml
new file mode 100644
index 000000000000..4aa36903e755
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml
@@ -0,0 +1,99 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/atmel,hlcdc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel's HLCD Controller
+
+maintainers:
+  - Nicolas Ferre <nicolas.ferre@microchip.com>
+  - Alexandre Belloni <alexandre.belloni@bootlin.com>
+  - Claudiu Beznea <claudiu.beznea@tuxon.dev>
+
+description:
+  The Atmel HLCDC (HLCD Controller) IP available on Atmel SoCs exposes two
+  subdevices, a PWM chip and a Display Controller.
+
+properties:
+  compatible:
+    enum:
+      - atmel,at91sam9n12-hlcdc
+      - atmel,at91sam9x5-hlcdc
+      - atmel,sama5d2-hlcdc
+      - atmel,sama5d3-hlcdc
+      - atmel,sama5d4-hlcdc
+      - microchip,sam9x60-hlcdc
+      - microchip,sam9x75-xlcdc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 3
+
+  clock-names:
+    items:
+      - const: periph_clk
+      - const: sys_clk
+      - const: slow_clk
+      - const: lvds_pll_clk
+    minItems: 3
+
+  display-controller:
+    $ref: /schemas/display/atmel/atmel,hlcdc-display-controller.yaml
+
+  pwm:
+    $ref: /schemas/pwm/atmel,hlcdc-pwm.yaml
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/at91.h>
+    #include <dt-bindings/dma/at91.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    lcd_controller: lcd-controller@f0030000 {
+      compatible = "atmel,sama5d3-hlcdc";
+      reg = <0xf0030000 0x2000>;
+      clocks = <&lcdc_clk>, <&lcdck>, <&clk32k>;
+      clock-names = "periph_clk", "sys_clk", "slow_clk";
+      interrupts = <36 IRQ_TYPE_LEVEL_HIGH 0>;
+
+      display-controller {
+        compatible = "atmel,hlcdc-display-controller";
+        pinctrl-names = "default";
+        pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        port@0 {
+          #address-cells = <1>;
+          #size-cells = <0>;
+          reg = <0>;
+
+          hlcdc_panel_output: endpoint@0 {
+            reg = <0>;
+            remote-endpoint = <&panel_input>;
+          };
+        };
+      };
+
+      pwm {
+        compatible = "atmel,hlcdc-pwm";
+        pinctrl-names = "default";
+        pinctrl-0 = <&pinctrl_lcd_pwm>;
+        #pwm-cells = <3>;
+      };
+    };
diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
deleted file mode 100644
index 7de696eefaed..000000000000
--- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
+++ /dev/null
@@ -1,56 +0,0 @@ 
-Device-Tree bindings for Atmel's HLCDC (High LCD Controller) MFD driver
-
-Required properties:
- - compatible: value should be one of the following:
-   "atmel,at91sam9n12-hlcdc"
-   "atmel,at91sam9x5-hlcdc"
-   "atmel,sama5d2-hlcdc"
-   "atmel,sama5d3-hlcdc"
-   "atmel,sama5d4-hlcdc"
-   "microchip,sam9x60-hlcdc"
-   "microchip,sam9x75-xlcdc"
- - reg: base address and size of the HLCDC device registers.
- - clock-names: the name of the 3 clocks requested by the HLCDC device.
-   Should contain "periph_clk", "sys_clk" and "slow_clk".
- - clocks: should contain the 3 clocks requested by the HLCDC device.
- - interrupts: should contain the description of the HLCDC interrupt line
-
-The HLCDC IP exposes two subdevices:
- - a PWM chip: see ../pwm/atmel-hlcdc-pwm.txt
- - a Display Controller: see ../display/atmel/hlcdc-dc.txt
-
-Example:
-
-	hlcdc: hlcdc@f0030000 {
-		compatible = "atmel,sama5d3-hlcdc";
-		reg = <0xf0030000 0x2000>;
-		clocks = <&lcdc_clk>, <&lcdck>, <&clk32k>;
-		clock-names = "periph_clk","sys_clk", "slow_clk";
-		interrupts = <36 IRQ_TYPE_LEVEL_HIGH 0>;
-
-		hlcdc-display-controller {
-			compatible = "atmel,hlcdc-display-controller";
-			pinctrl-names = "default";
-			pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>;
-			#address-cells = <1>;
-			#size-cells = <0>;
-
-			port@0 {
-				#address-cells = <1>;
-				#size-cells = <0>;
-				reg = <0>;
-
-				hlcdc_panel_output: endpoint@0 {
-					reg = <0>;
-					remote-endpoint = <&panel_input>;
-				};
-			};
-		};
-
-		hlcdc_pwm: hlcdc-pwm {
-			compatible = "atmel,hlcdc-pwm";
-			pinctrl-names = "default";
-			pinctrl-0 = <&pinctrl_lcd_pwm>;
-			#pwm-cells = <3>;
-		};
-	};