| Message ID | 20230228135508.1798428-3-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Superseded |
| Delegated to: | Thierry Reding |
| Headers | show |
| Series | pwm: Ensure .polarity is set in .get_state() | expand |
On Tue, Feb 28, 2023 at 5:55 AM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > The driver only supports normal polarity. Complete the implementation of > .get_state() by setting .polarity accordingly. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > drivers/pwm/pwm-cros-ec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c > index 86df6702cb83..ad18b0ebe3f1 100644 > --- a/drivers/pwm/pwm-cros-ec.c > +++ b/drivers/pwm/pwm-cros-ec.c > @@ -198,6 +198,7 @@ static int cros_ec_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > > state->enabled = (ret > 0); > state->period = EC_PWM_MAX_DUTY; > + state->polarity = PWM_POLARITY_NORMAL; > > /* > * Note that "disabled" and "duty cycle == 0" are treated the same. If > -- > 2.39.1 >
On Tue, Feb 28, 2023 at 02:55:06PM +0100, Uwe Kleine-König wrote: > The driver only supports normal polarity. Complete the implementation of > .get_state() by setting .polarity accordingly. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> I think we should apply this patch as a fix to prevent similar failures as reported for the meson driver. To justify that: Fixes: 1f0d3bb02785 ("pwm: Add ChromeOS EC PWM driver") Best regards Uwe
diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c index 86df6702cb83..ad18b0ebe3f1 100644 --- a/drivers/pwm/pwm-cros-ec.c +++ b/drivers/pwm/pwm-cros-ec.c @@ -198,6 +198,7 @@ static int cros_ec_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, state->enabled = (ret > 0); state->period = EC_PWM_MAX_DUTY; + state->polarity = PWM_POLARITY_NORMAL; /* * Note that "disabled" and "duty cycle == 0" are treated the same. If
The driver only supports normal polarity. Complete the implementation of .get_state() by setting .polarity accordingly. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pwm/pwm-cros-ec.c | 1 + 1 file changed, 1 insertion(+)