From patchwork Tue Feb 28 13:55:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1749478 X-Patchwork-Delegate: treding@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4PQzRS6Qj0z1yXC for ; Wed, 1 Mar 2023 00:56:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229580AbjB1N4D (ORCPT ); Tue, 28 Feb 2023 08:56:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbjB1N4D (ORCPT ); Tue, 28 Feb 2023 08:56:03 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2BA53019E for ; Tue, 28 Feb 2023 05:55:46 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Ru-0007wr-FS; Tue, 28 Feb 2023 14:55:22 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rr-000sd5-Fv; Tue, 28 Feb 2023 14:55:19 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rq-0011dd-QM; Tue, 28 Feb 2023 14:55:18 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata , Jiancheng Xue , yuanjian , Rob Herring Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/4] pwm: hibvt: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:05 +0100 Message-Id: <20230228135508.1798428-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=851; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=wc4XckGFK16wdwJ/Xdl4epfiuvV/IHKkEC7JDlgUzKg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/ges5DcD7InG+a9Dcii0vkRG0Z2rq8uudNNyL 1Dofr+8NjmJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HrAAKCRDB/BR4rcrs CTpaB/9LfzC8uQW9dLE0QEXLyQCUYsDAve9IntGqd6uLK6z8NZWmNYwkIkLnjwGQwqfIhpFtqp6 Xnc1NpZ0eQ5nAt2aPVu1lQRlXyI68NBtxE/xNf3sOpgrXpEU8CrGcSZ6BIiQ15g89hDuJAE/Bo1 vv76KL8LkxsVwcKgkTmBsKvhtNTZt+z0mC+6qCy+H9IIZZNfI0exVgaqF6OdjkEnJxz37AihCQf BJCrCJpn/98xLdjb08QXoRntq11gc4c7LU13hCJTPuQpkvQPqmqgS7FRLjjPp856CDHszepDKBp 7u17LXuJL6J6y2+sXxOnD3qxOrzjdnsblZ9FVgRlbt/iD0AQ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pwm@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org The driver only both polarities. Complete the implementation of .get_state() by setting .polarity according to the configured hardware state. Fixes: d09f00810850 ("pwm: Add PWM driver for HiSilicon BVT SOCs") Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-hibvt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-hibvt.c b/drivers/pwm/pwm-hibvt.c index 12c05c155cab..1b9274c5ad87 100644 --- a/drivers/pwm/pwm-hibvt.c +++ b/drivers/pwm/pwm-hibvt.c @@ -146,6 +146,7 @@ static int hibvt_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, value = readl(base + PWM_CTRL_ADDR(pwm->hwpwm)); state->enabled = (PWM_ENABLE_MASK & value); + state->polarity = (PWM_POLARITY_MASK & value) ? PWM_POLARITY_INVERSED : PWM_POLARITY_NORMAL; return 0; } From patchwork Tue Feb 28 13:55:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1749476 X-Patchwork-Delegate: treding@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4PQzQm1Tjjz1yXC for ; Wed, 1 Mar 2023 00:55:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbjB1Nz1 (ORCPT ); Tue, 28 Feb 2023 08:55:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbjB1Nz0 (ORCPT ); Tue, 28 Feb 2023 08:55:26 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BDDA2FCE3 for ; Tue, 28 Feb 2023 05:55:25 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Rt-0007wv-33; Tue, 28 Feb 2023 14:55:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rr-000sdC-Si; Tue, 28 Feb 2023 14:55:19 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rr-0011dg-0Q; Tue, 28 Feb 2023 14:55:19 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata , Benson Leung Cc: Guenter Roeck , linux-pwm@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/4] pwm: cros-ec: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:06 +0100 Message-Id: <20230228135508.1798428-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=749; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=IAtiCGV0wRa2U+/PppANZkZKRqaD1N3SRiIodPKqHTk=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/gevfhS7IyOpnmkoKmE420NdX4odBQ8eZG4d2 I2ybrXNvZCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HrwAKCRDB/BR4rcrs Ceq2B/9uCvaS+h95L+nfKjNahQfxtSyvPKw84Bl5AdHl2eN8Dy3mvqKAj725tx3O8JoslREBw4/ k1yU9cCbtDN000837fApwnhAo5parWgJLsStdKIuE8ddcjtwTFLlku5s7gtUkPT/DxCAb7pE9Wz jsltzncD+SOAQAJi2mZqE1GYrVMBTqUDc5JtB1RW/Z0H4/jq00y1p4T9i8Xxhy4N8LpYeax+Xnu gYp9kfIyT/KWyGBhbndnN+QCxFC8kgs03aonHEF8uflNO3hVQwOAnRJFqN3tLWwBnvZpZJaKOEf nuL3FO6V8tuHZwwslunaK8Ex15qdmjfaNLhFqXxRhVXOpWF1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pwm@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org The driver only supports normal polarity. Complete the implementation of .get_state() by setting .polarity accordingly. Signed-off-by: Uwe Kleine-König Reviewed-by: Guenter Roeck --- drivers/pwm/pwm-cros-ec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c index 86df6702cb83..ad18b0ebe3f1 100644 --- a/drivers/pwm/pwm-cros-ec.c +++ b/drivers/pwm/pwm-cros-ec.c @@ -198,6 +198,7 @@ static int cros_ec_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, state->enabled = (ret > 0); state->period = EC_PWM_MAX_DUTY; + state->polarity = PWM_POLARITY_NORMAL; /* * Note that "disabled" and "duty cycle == 0" are treated the same. If From patchwork Tue Feb 28 13:55:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1749475 X-Patchwork-Delegate: treding@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4PQzQk2SWpz1yXC for ; Wed, 1 Mar 2023 00:55:26 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229723AbjB1NzY (ORCPT ); Tue, 28 Feb 2023 08:55:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbjB1NzX (ORCPT ); Tue, 28 Feb 2023 08:55:23 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68DB91EBEF for ; Tue, 28 Feb 2023 05:55:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Rs-0007wu-FG; Tue, 28 Feb 2023 14:55:20 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rr-000sd9-QY; Tue, 28 Feb 2023 14:55:19 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rr-0011dj-61; Tue, 28 Feb 2023 14:55:19 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/4] pwm: iqs620a: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:07 +0100 Message-Id: <20230228135508.1798428-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=695; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=oFx9sWQeOcwK9tph3SLBT8A0PAe+uJ+yMPKcDB2SV6g=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/gezGzP7hFeDYYO3McBYrDAocsVr1s8ooAAwU 72jqr0StXGJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HswAKCRDB/BR4rcrs CTM8B/96zKiaRWSNjbH003KQRBpIIUk86CaI410ZsKGBCyV0v6djqh/onhyaXAYC+W4nqNVMXLz mxQ24yUJjuQ12Lp9ZjG0NwkuCXQtgQ9Ob1HeqgWwaojpVWV0y0hQPo3s0Pip3SdJAe26QmPsTX7 Thfbp3kCQ3QH7keDvzkuU9eceLmtH5RdHFjKHsHLjloTbMNfH2/Fj3AxsMF3ZnUkL5elLKX+5NB YV/mnpLa85ujstFIAT08S6efYP2TwSz/2OBwvLl48h3tRkO1RmwX3Ckk3ElqzJ9/YbqziRfYjsI lWAaKOx6GRUApZFTmhVMAgeb+M6sMDEvq5k0YU4YIfK4l1U5 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pwm@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org The driver only supports normal polarity. Complete the implementation of .get_state() by setting .polarity accordingly. Signed-off-by: Uwe Kleine-König Reviewed-by: Jeff LaBundy --- drivers/pwm/pwm-iqs620a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-iqs620a.c b/drivers/pwm/pwm-iqs620a.c index 8362b4870c66..47b3141135f3 100644 --- a/drivers/pwm/pwm-iqs620a.c +++ b/drivers/pwm/pwm-iqs620a.c @@ -126,6 +126,7 @@ static int iqs620_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, mutex_unlock(&iqs620_pwm->lock); state->period = IQS620_PWM_PERIOD_NS; + state->polarity = PWM_POLARITY_NORMAL; return 0; } From patchwork Tue Feb 28 13:55:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1749477 X-Patchwork-Delegate: treding@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4PQzQn3Bx7z1yXC for ; Wed, 1 Mar 2023 00:55:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbjB1Nz2 (ORCPT ); Tue, 28 Feb 2023 08:55:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbjB1Nz1 (ORCPT ); Tue, 28 Feb 2023 08:55:27 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 454B41EBEF for ; Tue, 28 Feb 2023 05:55:26 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Rt-0007wy-2Z; Tue, 28 Feb 2023 14:55:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rs-000sdF-0S; Tue, 28 Feb 2023 14:55:20 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rr-0011e4-CB; Tue, 28 Feb 2023 14:55:19 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 4/4] pwm: sprd: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:08 +0100 Message-Id: <20230228135508.1798428-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=824; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=bmf2HoXP9Rt5LT3z0AtFgY3qIfAp4/hwx1OXH8EwlFw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/ge2KHuAInQ+QDahQS2YY03DGST7KS6YuYIAG cCGk1az48GJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HtgAKCRDB/BR4rcrs CbNsB/9xAqs3WfLL+n74CI2B0P7vOauSZIUEMz7vuNJ1o8YDjSnmlkDtdJr4LA7olD3QWLXFyG2 QzZJSGsglYbR8rn87eemML3a8r3wiDlqeInSg4C1Ol5U9vDQLlOijd3c4BwWuKDDJCgzCt05Adi fVkCwABcaQteeTcFE3bwoLhFk14vTzmoGtp8Lb5teawf22xNNDd45/vAolptfbuFSv1s2qHKRP6 gT9zP4OIVm/x2QRC0/aH/tzfBI1zTQy6G55Az274UHAktxCPGvZmh3KM6KCC6ngEmfDXR99MF3w Q0DwLe7vriTk0Gly0sx2tEe9u84tUscrbYL3+Uh6Q88FCDR8 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pwm@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org The driver only supports normal polarity. Complete the implementation of .get_state() by setting .polarity accordingly. Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-sprd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c index d866ce345f97..bde579a338c2 100644 --- a/drivers/pwm/pwm-sprd.c +++ b/drivers/pwm/pwm-sprd.c @@ -109,6 +109,7 @@ static int sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, duty = val & SPRD_PWM_DUTY_MSK; tmp = (prescale + 1) * NSEC_PER_SEC * duty; state->duty_cycle = DIV_ROUND_CLOSEST_ULL(tmp, chn->clk_rate); + state->polarity = PWM_POLARITY_NORMAL; /* Disable PWM clocks if the PWM channel is not in enable state. */ if (!state->enabled)