| Message ID | 20210412200155.5316-1-jbx6244@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3,1/4] dt-bindings: pwm: convert pwm-rockchip.txt to YAML | expand |
On Mon, 12 Apr 2021 22:01:52 +0200, Johan Jonker wrote: > Current dts files with 'pwm' nodes are manually verified. > In order to automate this process pwm-rockchip.txt > has to be converted to yaml. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > For some SoC nodes this patch serie generates notifications > for undocumented "interrupts" properties shared between > PWM channels till there is consensus of what to do with it or > someone makes a solution for the whole PWM block. > > Changed V3: > fix mistake with compatibles introduced in V2 > Changed V2: > changed schema for clocks and clock-names > --- > .../devicetree/bindings/pwm/pwm-rockchip.txt | 27 ------- > .../devicetree/bindings/pwm/pwm-rockchip.yaml | 88 ++++++++++++++++++++++ > 2 files changed, 88 insertions(+), 27 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.txt > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Apr 12, 2021 at 10:01:52PM +0200, Johan Jonker wrote: > Current dts files with 'pwm' nodes are manually verified. > In order to automate this process pwm-rockchip.txt > has to be converted to yaml. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > For some SoC nodes this patch serie generates notifications > for undocumented "interrupts" properties shared between > PWM channels till there is consensus of what to do with it or > someone makes a solution for the whole PWM block. > > Changed V3: > fix mistake with compatibles introduced in V2 > Changed V2: > changed schema for clocks and clock-names > --- > .../devicetree/bindings/pwm/pwm-rockchip.txt | 27 ------- > .../devicetree/bindings/pwm/pwm-rockchip.yaml | 88 ++++++++++++++++++++++ > 2 files changed, 88 insertions(+), 27 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.txt > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml Heiko, do you want to pick up patches 1 & 2 into your tree along with 3 & 4? If so: Acked-by: Thierry Reding <thierry.reding@gmail.com>
Hi Thierry, Am Dienstag, 13. April 2021, 17:21:49 CEST schrieb Thierry Reding: > On Mon, Apr 12, 2021 at 10:01:52PM +0200, Johan Jonker wrote: > > Current dts files with 'pwm' nodes are manually verified. > > In order to automate this process pwm-rockchip.txt > > has to be converted to yaml. > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > --- > > For some SoC nodes this patch serie generates notifications > > for undocumented "interrupts" properties shared between > > PWM channels till there is consensus of what to do with it or > > someone makes a solution for the whole PWM block. > > > > Changed V3: > > fix mistake with compatibles introduced in V2 > > Changed V2: > > changed schema for clocks and clock-names > > --- > > .../devicetree/bindings/pwm/pwm-rockchip.txt | 27 ------- > > .../devicetree/bindings/pwm/pwm-rockchip.yaml | 88 ++++++++++++++++++++++ > > 2 files changed, 88 insertions(+), 27 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.txt > > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > > Heiko, do you want to pick up patches 1 & 2 into your tree along with 3 & 4? If so: > > Acked-by: Thierry Reding <thierry.reding@gmail.com> however you like :-) I can pick up everything for 5.14 for sure. Depending on your tree-schedule for the merge-window, you could also pick up all 4 with my: Acked-by: Heiko Stuebner <heiko@sntech.de> Heiko
On Mon, Apr 12, 2021 at 10:01:52PM +0200, Johan Jonker wrote: > Current dts files with 'pwm' nodes are manually verified. > In order to automate this process pwm-rockchip.txt > has to be converted to yaml. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > For some SoC nodes this patch serie generates notifications > for undocumented "interrupts" properties shared between > PWM channels till there is consensus of what to do with it or > someone makes a solution for the whole PWM block. > > Changed V3: > fix mistake with compatibles introduced in V2 > Changed V2: > changed schema for clocks and clock-names > --- > .../devicetree/bindings/pwm/pwm-rockchip.txt | 27 ------- > .../devicetree/bindings/pwm/pwm-rockchip.yaml | 88 ++++++++++++++++++++++ > 2 files changed, 88 insertions(+), 27 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.txt > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml All 4 patches applied, thanks. Thierry
diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt b/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt deleted file mode 100644 index f70956dea..000000000 --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt +++ /dev/null @@ -1,27 +0,0 @@ -Rockchip PWM controller - -Required properties: - - compatible: should be "rockchip,<name>-pwm" - "rockchip,rk2928-pwm": found on RK29XX,RK3066 and RK3188 SoCs - "rockchip,rk3288-pwm": found on RK3288 SOC - "rockchip,rv1108-pwm", "rockchip,rk3288-pwm": found on RV1108 SoC - "rockchip,vop-pwm": found integrated in VOP on RK3288 SoC - - reg: physical base address and length of the controller's registers - - clocks: See ../clock/clock-bindings.txt - - For older hardware (rk2928, rk3066, rk3188, rk3228, rk3288, rk3399): - - There is one clock that's used both to derive the functional clock - for the device and as the bus clock. - - For newer hardware (rk3328 and future socs): specified by name - - "pwm": This is used to derive the functional clock. - - "pclk": This is the APB bus clock. - - #pwm-cells: must be 2 (rk2928) or 3 (rk3288). See pwm.yaml in this directory - for a description of the cell format. - -Example: - - pwm0: pwm@20030000 { - compatible = "rockchip,rk2928-pwm"; - reg = <0x20030000 0x10>; - clocks = <&cru PCLK_PWM01>; - #pwm-cells = <2>; - }; diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml new file mode 100644 index 000000000..19b42d31d --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml @@ -0,0 +1,88 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/pwm-rockchip.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip PWM controller + +maintainers: + - Heiko Stuebner <heiko@sntech.de> + +properties: + compatible: + oneOf: + - const: rockchip,rk2928-pwm + - const: rockchip,rk3288-pwm + - const: rockchip,vop-pwm + - items: + - enum: + - rockchip,rv1108-pwm + - const: rockchip,rk3288-pwm + + reg: + maxItems: 1 + + clocks: + minItems: 1 + maxItems: 2 + + clock-names: + maxItems: 2 + + "#pwm-cells": + enum: [2, 3] + description: + Must be 2 (rk2928) or 3 (rk3288 and later). + See pwm.yaml for a description of the cell format. + +required: + - compatible + - reg + - "#pwm-cells" + +if: + properties: + compatible: + contains: + enum: + - rockchip,rv1108-pwm + +then: + properties: + clocks: + items: + - description: Used to derive the functional clock for the device. + - description: Used as the APB bus clock. + + clock-names: + items: + - const: pwm + - const: pclk + + required: + - clocks + - clock-names + +else: + properties: + clocks: + maxItems: 1 + description: + Used both to derive the functional clock + for the device and as the bus clock. + + required: + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/rk3188-cru-common.h> + pwm0: pwm@20030000 { + compatible = "rockchip,rk2928-pwm"; + reg = <0x20030000 0x10>; + clocks = <&cru PCLK_PWM01>; + #pwm-cells = <2>; + };
Current dts files with 'pwm' nodes are manually verified. In order to automate this process pwm-rockchip.txt has to be converted to yaml. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- For some SoC nodes this patch serie generates notifications for undocumented "interrupts" properties shared between PWM channels till there is consensus of what to do with it or someone makes a solution for the whole PWM block. Changed V3: fix mistake with compatibles introduced in V2 Changed V2: changed schema for clocks and clock-names --- .../devicetree/bindings/pwm/pwm-rockchip.txt | 27 ------- .../devicetree/bindings/pwm/pwm-rockchip.yaml | 88 ++++++++++++++++++++++ 2 files changed, 88 insertions(+), 27 deletions(-) delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.txt create mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml