| Message ID | 20231220213615.1561528-16-Frank.Li@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: imx6: Clean up and add imx95 pci support | expand |
On 20/12/2023 22:36, Frank Li wrote: > Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string. > Add reg-name: "atu", "dbi2", "dma" and "serdes". > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > > Notes: > Change from v1 to v3 > - new patches at v3 > > .../bindings/pci/fsl,imx6q-pcie-ep.yaml | 52 ++++++++++++++++--- > 1 file changed, 44 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > index ee155ed5f1811..be9ea77ce8548 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > @@ -22,14 +22,7 @@ properties: > - fsl,imx8mm-pcie-ep > - fsl,imx8mq-pcie-ep > - fsl,imx8mp-pcie-ep > - > - reg: > - minItems: 2 > - > - reg-names: > - items: > - - const: dbi > - - const: addr_space No, why? Entries should be defined top-level. If you remove them here, where are they defined (in which schema)? > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx95-pcie-ep > + then: > + properties: > + linux,pci-domain: true Why? It is allowed already. Best regards, Krzysztof
On Sat, Dec 23, 2023 at 07:44:30PM +0100, Krzysztof Kozlowski wrote: > On 20/12/2023 22:36, Frank Li wrote: > > Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string. > > Add reg-name: "atu", "dbi2", "dma" and "serdes". > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > > > Notes: > > Change from v1 to v3 > > - new patches at v3 > > > > .../bindings/pci/fsl,imx6q-pcie-ep.yaml | 52 ++++++++++++++++--- > > 1 file changed, 44 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > > index ee155ed5f1811..be9ea77ce8548 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > > @@ -22,14 +22,7 @@ properties: > > - fsl,imx8mm-pcie-ep > > - fsl,imx8mq-pcie-ep > > - fsl,imx8mp-pcie-ep > > - > > - reg: > > - minItems: 2 > > - > > - reg-names: > > - items: > > - - const: dbi > > - - const: addr_space > > No, why? Entries should be defined top-level. If you remove them here, > where are they defined (in which schema)? See: pci/snps,dw-pcie.yaml > > > > + - if: > > + properties: > > + compatible: > > + enum: > > + - fsl,imx95-pcie-ep > > + then: > > + properties: > > + linux,pci-domain: true > > Why? It is allowed already. Sorry, I suppose it should be required. I will fix it. > > > Best regards, > Krzysztof >
On 20/12/2023 22:36, Frank Li wrote: > + then: > + properties: > + reg: > + minItems: 2 Missing maxItems. > + reg-names: > + items: > + - const: dbi > + - const: addr_space > + > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx95-pcie-ep > + then: > + properties: > + reg: > + minItems: 6 Missing maxItems. Best regards, Krzysztof
On 24/12/2023 05:47, Frank Li wrote: > On Sat, Dec 23, 2023 at 07:44:30PM +0100, Krzysztof Kozlowski wrote: >> On 20/12/2023 22:36, Frank Li wrote: >>> Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string. >>> Add reg-name: "atu", "dbi2", "dma" and "serdes". >>> >>> Signed-off-by: Frank Li <Frank.Li@nxp.com> >>> --- >>> >>> Notes: >>> Change from v1 to v3 >>> - new patches at v3 >>> >>> .../bindings/pci/fsl,imx6q-pcie-ep.yaml | 52 ++++++++++++++++--- >>> 1 file changed, 44 insertions(+), 8 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml >>> index ee155ed5f1811..be9ea77ce8548 100644 >>> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml >>> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml >>> @@ -22,14 +22,7 @@ properties: >>> - fsl,imx8mm-pcie-ep >>> - fsl,imx8mq-pcie-ep >>> - fsl,imx8mp-pcie-ep >>> - >>> - reg: >>> - minItems: 2 >>> - >>> - reg-names: >>> - items: >>> - - const: dbi >>> - - const: addr_space >> >> No, why? Entries should be defined top-level. If you remove them here, >> where are they defined (in which schema)? > > See: pci/snps,dw-pcie.yaml OK Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml index ee155ed5f1811..be9ea77ce8548 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml @@ -22,14 +22,7 @@ properties: - fsl,imx8mm-pcie-ep - fsl,imx8mq-pcie-ep - fsl,imx8mp-pcie-ep - - reg: - minItems: 2 - - reg-names: - items: - - const: dbi - - const: addr_space + - fsl,imx95-pcie-ep clocks: minItems: 3 @@ -62,11 +55,46 @@ required: allOf: - $ref: /schemas/pci/snps,dw-pcie-ep.yaml# - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# + - if: + properties: + compatible: + enum: + - fsl,imx8mm-pcie-ep + - fsl,imx8mq-pcie-ep + - fsl,imx8mp-pcie-ep + then: + properties: + reg: + minItems: 2 + reg-names: + items: + - const: dbi + - const: addr_space + + - if: + properties: + compatible: + enum: + - fsl,imx95-pcie-ep + then: + properties: + reg: + minItems: 6 + reg-names: + items: + - const: dbi + - const: atu + - const: dbi2 + - const: app + - const: dma + - const: addr_space + - if: properties: compatible: enum: - fsl,imx8mq-pcie-ep + - fsl,imx95-pcie-ep then: properties: clocks: @@ -87,6 +115,14 @@ allOf: - const: pcie_bus - const: pcie_aux + - if: + properties: + compatible: + enum: + - fsl,imx95-pcie-ep + then: + properties: + linux,pci-domain: true unevaluatedProperties: false
Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string. Add reg-name: "atu", "dbi2", "dma" and "serdes". Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Notes: Change from v1 to v3 - new patches at v3 .../bindings/pci/fsl,imx6q-pcie-ep.yaml | 52 ++++++++++++++++--- 1 file changed, 44 insertions(+), 8 deletions(-)