diff mbox series

[v5,10/16] dt-bindings: imx6q-pcie: remove reg and reg-name

Message ID 20231220213615.1561528-11-Frank.Li@nxp.com
State New
Headers show
Series PCI: imx6: Clean up and add imx95 pci support | expand

Commit Message

Frank Li Dec. 20, 2023, 9:36 p.m. UTC 
snps,dw-pcie.yaml already have reg and reg-name information. Needn't
duplciate here.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v4 to v5
    - add Rob's Acked
    Change from v1 to v4:
    - new patch at v4

 .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml        | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Rob Herring (Arm) Dec. 21, 2023, 10:50 p.m. UTC | #1 
On Wed, Dec 20, 2023 at 04:36:09PM -0500, Frank Li wrote:
> snps,dw-pcie.yaml already have reg and reg-name information. Needn't
> duplciate here.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>     Change from v4 to v5
>     - add Rob's Acked

Err, that was intended for patch 9, not this one. This patch should be 
dropped.

>     Change from v1 to v4:
>     - new patch at v4
> 
>  .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml        | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 81bbb8728f0f9..f20d4f0e3cb6c 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -30,16 +30,6 @@ properties:
>        - fsl,imx8mm-pcie
>        - fsl,imx8mp-pcie
>  
> -  reg:
> -    items:
> -      - description: Data Bus Interface (DBI) registers.
> -      - description: PCIe configuration space region.
> -
> -  reg-names:
> -    items:
> -      - const: dbi
> -      - const: config
> -
>    clocks:
>      minItems: 3
>      items:
> -- 
> 2.34.1
>
Frank Li Dec. 23, 2023, 3:46 a.m. UTC | #2 
On Thu, Dec 21, 2023 at 04:50:33PM -0600, Rob Herring wrote:
> On Wed, Dec 20, 2023 at 04:36:09PM -0500, Frank Li wrote:
> > snps,dw-pcie.yaml already have reg and reg-name information. Needn't
> > duplciate here.
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > 
> > Notes:
> >     Change from v4 to v5
> >     - add Rob's Acked
> 
> Err, that was intended for patch 9, not this one. This patch should be 
> dropped.

Sorry, will correct it.

Actually I want to move it under Allof

if compatiable string (A, B, C...)
then
	reg-names:
		-const: dbi
		-const: config

Differece SOC have difference reg-names required list. If split it, it
will be easy when add new SOC. Needn't change two place.

Let me update at next version.


> 
> >     Change from v1 to v4:
> >     - new patch at v4
> > 
> >  .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml        | 10 ----------
> >  1 file changed, 10 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > index 81bbb8728f0f9..f20d4f0e3cb6c 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > @@ -30,16 +30,6 @@ properties:
> >        - fsl,imx8mm-pcie
> >        - fsl,imx8mp-pcie
> >  
> > -  reg:
> > -    items:
> > -      - description: Data Bus Interface (DBI) registers.
> > -      - description: PCIe configuration space region.
> > -
> > -  reg-names:
> > -    items:
> > -      - const: dbi
> > -      - const: config
> > -
> >    clocks:
> >      minItems: 3
> >      items:
> > -- 
> > 2.34.1
> >
Krzysztof Kozlowski Dec. 23, 2023, 6:43 p.m. UTC | #3 
On 23/12/2023 04:46, Frank Li wrote:
> On Thu, Dec 21, 2023 at 04:50:33PM -0600, Rob Herring wrote:
>> On Wed, Dec 20, 2023 at 04:36:09PM -0500, Frank Li wrote:
>>> snps,dw-pcie.yaml already have reg and reg-name information. Needn't
>>> duplciate here.
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>>
>>> Notes:
>>>     Change from v4 to v5
>>>     - add Rob's Acked
>>
>> Err, that was intended for patch 9, not this one. This patch should be 
>> dropped.
> 
> Sorry, will correct it.
> 
> Actually I want to move it under Allof
> 
> if compatiable string (A, B, C...)
> then
> 	reg-names:
> 		-const: dbi
> 		-const: config
> 
> Differece SOC have difference reg-names required list. If split it, it
> will be easy when add new SOC. Needn't change two place.
> 
> Let me update at next version.
> 

This patch should be dropped. Why do you remove entries from top-level?
Are they defined in other schema?

Best regards,
Krzysztof
Frank Li Dec. 24, 2023, 4:34 a.m. UTC | #4 
On Sat, Dec 23, 2023 at 07:43:01PM +0100, Krzysztof Kozlowski wrote:
> On 23/12/2023 04:46, Frank Li wrote:
> > On Thu, Dec 21, 2023 at 04:50:33PM -0600, Rob Herring wrote:
> >> On Wed, Dec 20, 2023 at 04:36:09PM -0500, Frank Li wrote:
> >>> snps,dw-pcie.yaml already have reg and reg-name information. Needn't
> >>> duplciate here.
> >>>
> >>> Acked-by: Rob Herring <robh@kernel.org>
> >>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >>> ---
> >>>
> >>> Notes:
> >>>     Change from v4 to v5
> >>>     - add Rob's Acked
> >>
> >> Err, that was intended for patch 9, not this one. This patch should be 
> >> dropped.
> > 
> > Sorry, will correct it.
> > 
> > Actually I want to move it under Allof
> > 
> > if compatiable string (A, B, C...)
> > then
> > 	reg-names:
> > 		-const: dbi
> > 		-const: config
> > 
> > Differece SOC have difference reg-names required list. If split it, it
> > will be easy when add new SOC. Needn't change two place.
> > 
> > Let me update at next version.
> > 
> 
> This patch should be dropped. Why do you remove entries from top-level?
> Are they defined in other schema?

pci/snps,dw-pcie.yaml already define it.

Frank

> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Dec. 24, 2023, 9:06 a.m. UTC | #5 
On 24/12/2023 05:34, Frank Li wrote:
> On Sat, Dec 23, 2023 at 07:43:01PM +0100, Krzysztof Kozlowski wrote:
>> On 23/12/2023 04:46, Frank Li wrote:
>>> On Thu, Dec 21, 2023 at 04:50:33PM -0600, Rob Herring wrote:
>>>> On Wed, Dec 20, 2023 at 04:36:09PM -0500, Frank Li wrote:
>>>>> snps,dw-pcie.yaml already have reg and reg-name information. Needn't
>>>>> duplciate here.
>>>>>
>>>>> Acked-by: Rob Herring <robh@kernel.org>
>>>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>>>> ---
>>>>>
>>>>> Notes:
>>>>>     Change from v4 to v5
>>>>>     - add Rob's Acked
>>>>
>>>> Err, that was intended for patch 9, not this one. This patch should be 
>>>> dropped.
>>>
>>> Sorry, will correct it.
>>>
>>> Actually I want to move it under Allof
>>>
>>> if compatiable string (A, B, C...)
>>> then
>>> 	reg-names:
>>> 		-const: dbi
>>> 		-const: config
>>>
>>> Differece SOC have difference reg-names required list. If split it, it
>>> will be easy when add new SOC. Needn't change two place.
>>>
>>> Let me update at next version.
>>>
>>
>> This patch should be dropped. Why do you remove entries from top-level?
>> Are they defined in other schema?
> 
> pci/snps,dw-pcie.yaml already define it.

Indeed I see you wrote it in commit msg. However snps,dwc-pcie has it in
 an unconstrained way. Nothing in commit msg suggests there are
constrains somewhere.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 81bbb8728f0f9..f20d4f0e3cb6c 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -30,16 +30,6 @@  properties:
       - fsl,imx8mm-pcie
       - fsl,imx8mp-pcie
 
-  reg:
-    items:
-      - description: Data Bus Interface (DBI) registers.
-      - description: PCIe configuration space region.
-
-  reg-names:
-    items:
-      - const: dbi
-      - const: config
-
   clocks:
     minItems: 3
     items: