| Message ID | 20200427082028.394719-4-boris.brezillon@collabora.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | mtd: rawnand: cafe: Convert to exec_op() (and more) | expand |
Hi Boris, Boris Brezillon <boris.brezillon@collabora.com> wrote on Mon, 27 Apr 2020 10:20:13 +0200: > The NAND_ECC_HW_SYNDROME name is a bit misleading. It's actually used > for drivers that interleave data and ECC bytes inside a page, which is > not the case here. Let's fix that and pass the ECC algorithm used by the > ECC engine. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/mtd/nand/raw/cafe_nand.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c > index 03964e092243..47aacfab8ecb 100644 > --- a/drivers/mtd/nand/raw/cafe_nand.c > +++ b/drivers/mtd/nand/raw/cafe_nand.c > @@ -624,7 +624,8 @@ static int cafe_nand_attach_chip(struct nand_chip *chip) > goto out_free_dma; > } > > - cafe->nand.ecc.mode = NAND_ECC_HW_SYNDROME; > + cafe->nand.ecc.mode = NAND_ECC_HW; > + cafe->nand.ecc.algo = NAND_ECC_RS; > cafe->nand.ecc.size = mtd->writesize; > cafe->nand.ecc.bytes = 14; > cafe->nand.ecc.strength = 4; Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c index 03964e092243..47aacfab8ecb 100644 --- a/drivers/mtd/nand/raw/cafe_nand.c +++ b/drivers/mtd/nand/raw/cafe_nand.c @@ -624,7 +624,8 @@ static int cafe_nand_attach_chip(struct nand_chip *chip) goto out_free_dma; } - cafe->nand.ecc.mode = NAND_ECC_HW_SYNDROME; + cafe->nand.ecc.mode = NAND_ECC_HW; + cafe->nand.ecc.algo = NAND_ECC_RS; cafe->nand.ecc.size = mtd->writesize; cafe->nand.ecc.bytes = 14; cafe->nand.ecc.strength = 4;
The NAND_ECC_HW_SYNDROME name is a bit misleading. It's actually used for drivers that interleave data and ECC bytes inside a page, which is not the case here. Let's fix that and pass the ECC algorithm used by the ECC engine. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> --- drivers/mtd/nand/raw/cafe_nand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)