| Message ID | 20200427082028.394719-3-boris.brezillon@collabora.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | mtd: rawnand: cafe: Convert to exec_op() (and more) | expand |
Hi Boris, Boris Brezillon <boris.brezillon@collabora.com> wrote on Mon, 27 Apr 2020 10:20:12 +0200: > Let's rename that one cafe_nand_write_page() to be consistent with other > function names. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/mtd/nand/raw/cafe_nand.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c > index 1296380a4996..03964e092243 100644 > --- a/drivers/mtd/nand/raw/cafe_nand.c > +++ b/drivers/mtd/nand/raw/cafe_nand.c > @@ -525,9 +525,9 @@ static struct nand_bbt_descr cafe_bbt_mirror_descr_512 = { > }; > > > -static int cafe_nand_write_page_lowlevel(struct nand_chip *chip, > - const uint8_t *buf, int oob_required, > - int page) > +static int cafe_nand_write_page(struct nand_chip *chip, > + const uint8_t *buf, int oob_required, > + int page) > { > struct mtd_info *mtd = nand_to_mtd(chip); > struct cafe_priv *cafe = nand_get_controller_data(chip); > @@ -628,7 +628,7 @@ static int cafe_nand_attach_chip(struct nand_chip *chip) > cafe->nand.ecc.size = mtd->writesize; > cafe->nand.ecc.bytes = 14; > cafe->nand.ecc.strength = 4; > - cafe->nand.ecc.write_page = cafe_nand_write_page_lowlevel; > + cafe->nand.ecc.write_page = cafe_nand_write_page; > cafe->nand.ecc.write_oob = cafe_nand_write_oob; > cafe->nand.ecc.read_page = cafe_nand_read_page; > cafe->nand.ecc.read_oob = cafe_nand_read_oob; Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c index 1296380a4996..03964e092243 100644 --- a/drivers/mtd/nand/raw/cafe_nand.c +++ b/drivers/mtd/nand/raw/cafe_nand.c @@ -525,9 +525,9 @@ static struct nand_bbt_descr cafe_bbt_mirror_descr_512 = { }; -static int cafe_nand_write_page_lowlevel(struct nand_chip *chip, - const uint8_t *buf, int oob_required, - int page) +static int cafe_nand_write_page(struct nand_chip *chip, + const uint8_t *buf, int oob_required, + int page) { struct mtd_info *mtd = nand_to_mtd(chip); struct cafe_priv *cafe = nand_get_controller_data(chip); @@ -628,7 +628,7 @@ static int cafe_nand_attach_chip(struct nand_chip *chip) cafe->nand.ecc.size = mtd->writesize; cafe->nand.ecc.bytes = 14; cafe->nand.ecc.strength = 4; - cafe->nand.ecc.write_page = cafe_nand_write_page_lowlevel; + cafe->nand.ecc.write_page = cafe_nand_write_page; cafe->nand.ecc.write_oob = cafe_nand_write_oob; cafe->nand.ecc.read_page = cafe_nand_read_page; cafe->nand.ecc.read_oob = cafe_nand_read_oob;
Let's rename that one cafe_nand_write_page() to be consistent with other function names. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> --- drivers/mtd/nand/raw/cafe_nand.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)