mbox series

[v2,0/2] Add support to Disable the flash quad mode

Message ID 1594027356-19088-1-git-send-email-yangyicong@hisilicon.com
Headers show
Series Add support to Disable the flash quad mode | expand

Message

Yicong Yang July 6, 2020, 9:22 a.m. UTC 
Previously we didn't disable the flash's quad mode when it's removed
Then comes the problem that if we next time load the flash
in Standard/Dual SPI mode, the quad enable bits is not cleared,
and the function of flash's WP# and RESET#/HOLD# pin will not
be restored.

This series adds the capability to disable the flash's quad mode. And
restore the flash when it's removed in spi_nor_restore().

Change since v1:
- Address the comments by Tudor
- Reword the commit message in Patch 2/2. 

Yicong Yang (2):
  mtd: spi-nor: Add capability to disable flash quad mode
  mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()

 drivers/mtd/spi-nor/core.c | 57 ++++++++++++++++++++++++++++++----------------
 drivers/mtd/spi-nor/core.h | 10 ++++----
 2 files changed, 43 insertions(+), 24 deletions(-)

Comments

Tudor Ambarus July 13, 2020, 9:26 a.m. UTC | #1 
On Mon, 6 Jul 2020 17:22:34 +0800, Yicong Yang wrote:
> Previously we didn't disable the flash's quad mode when it's removed
> Then comes the problem that if we next time load the flash
> in Standard/Dual SPI mode, the quad enable bits is not cleared,
> and the function of flash's WP# and RESET#/HOLD# pin will not
> be restored.
> 
> This series adds the capability to disable the flash's quad mode. And
> restore the flash when it's removed in spi_nor_restore().
> 
> [...]

Applied to spi-nor/next, thanks!

[1/2] mtd: spi-nor: Add capability to disable flash quad mode
      https://git.kernel.org/mtd/c/be192209d5a3
[2/2] mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()
      https://git.kernel.org/mtd/c/cc59e6bb6cd6

Best regards,