| Message ID | 20200319122737.3063291-7-thierry.reding@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: tegra: Support SFIO/GPIO programming | expand |
On 3/19/2020 5:57 PM, Thierry Reding wrote: > External email: Use caution opening links or attachments > > > From: Thierry Reding <treding@nvidia.com> > > Pass the struct tegra_pmx when checking for the pin range in device > tree. This makes the call site a bit easier to read and will help keep > that readability in a subsequent patch. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c > index cefbbb8d1a68..c8246cc2c4fd 100644 > --- a/drivers/pinctrl/tegra/pinctrl-tegra.c > +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c > @@ -689,12 +689,12 @@ const struct dev_pm_ops tegra_pinctrl_pm = { > .resume = &tegra_pinctrl_resume > }; > > -static bool gpio_node_has_range(const char *compatible) > +static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx) > { > struct device_node *np; > bool has_prop = false; > > - np = of_find_compatible_node(NULL, NULL, compatible); > + np = of_find_compatible_node(NULL, NULL, pmx->soc->gpio_compatible); > if (!np) > return has_prop; > > @@ -794,7 +794,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev, > > tegra_pinctrl_clear_parked_bits(pmx); > > - if (!gpio_node_has_range(pmx->soc->gpio_compatible)) > + if (!tegra_pinctrl_gpio_node_has_range(pmx)) > pinctrl_add_gpio_range(pmx->pctl, &tegra_pinctrl_gpio_range); > > platform_set_drvdata(pdev, pmx); > -- > 2.24.1 > Tested-by: Vidya Sagar <vidyas@nvidia.com>
On Thu, Mar 19, 2020 at 1:27 PM Thierry Reding <thierry.reding@gmail.com> wrote: > From: Thierry Reding <treding@nvidia.com> > > Pass the struct tegra_pmx when checking for the pin range in device > tree. This makes the call site a bit easier to read and will help keep > that readability in a subsequent patch. > > Signed-off-by: Thierry Reding <treding@nvidia.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index cefbbb8d1a68..c8246cc2c4fd 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -689,12 +689,12 @@ const struct dev_pm_ops tegra_pinctrl_pm = { .resume = &tegra_pinctrl_resume }; -static bool gpio_node_has_range(const char *compatible) +static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx) { struct device_node *np; bool has_prop = false; - np = of_find_compatible_node(NULL, NULL, compatible); + np = of_find_compatible_node(NULL, NULL, pmx->soc->gpio_compatible); if (!np) return has_prop; @@ -794,7 +794,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev, tegra_pinctrl_clear_parked_bits(pmx); - if (!gpio_node_has_range(pmx->soc->gpio_compatible)) + if (!tegra_pinctrl_gpio_node_has_range(pmx)) pinctrl_add_gpio_range(pmx->pctl, &tegra_pinctrl_gpio_range); platform_set_drvdata(pdev, pmx);