diff mbox series

[5/6] riscv: Test for specific SBI implementation ID

Message ID 20240229124246.309304-6-cem@kernel.org
State Handled Elsewhere
Headers show
Series Add riscv tests to cover the base extension specs | expand

Commit Message

Carlos Maiolino Feb. 29, 2024, 12:42 p.m. UTC 
From: Carlos Maiolino <cem@kernel.org>

Retrieve the ID from the SBI, and test it against the SBI_IMPLID enviroment
variable.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 riscv/sbi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Andrew Jones March 1, 2024, 8:45 a.m. UTC | #1 
On Thu, Feb 29, 2024 at 01:42:11PM +0100, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Retrieve the ID from the SBI, and test it against the SBI_IMPLID enviroment
> variable.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
>  riscv/sbi.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/riscv/sbi.c b/riscv/sbi.c
> index 8ad8f375..9daab9dc 100644
> --- a/riscv/sbi.c
> +++ b/riscv/sbi.c
> @@ -54,6 +54,16 @@ static void check_base(void)
>  	}
>  	report_prefix_pop();
>  
> +	report_prefix_push("sbi_impl_id");
> +	if (env_is_defined("SBI_IMPLID")) {
> +		ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_GET_IMP_ID,
> +				SBI_EXT_BASE, 0, 0, 0, 0, 0);
> +		expected = strtol(getenv("SBI_IMPLID"), NULL, 0);
> +
> +		gen_report(&ret, expected);

nit: keep this sequence of lines consistent to make it easier for
readers, i.e. always use

   expected = ...
   ret = sbi_ecal(...
   gen_report(...

> +	}
> +	report_prefix_pop();
> +
>  	report_prefix_push("probe_ext");
>  	if (env_is_defined("PROBE_EXT")) {
>  		expected = strtol(getenv("PROBE_EXT"), NULL, 0);
> -- 
> 2.43.2
>

Otherwise,

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
diff mbox series

Patch

diff --git a/riscv/sbi.c b/riscv/sbi.c
index 8ad8f375..9daab9dc 100644
--- a/riscv/sbi.c
+++ b/riscv/sbi.c
@@ -54,6 +54,16 @@  static void check_base(void)
 	}
 	report_prefix_pop();
 
+	report_prefix_push("sbi_impl_id");
+	if (env_is_defined("SBI_IMPLID")) {
+		ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_GET_IMP_ID,
+				SBI_EXT_BASE, 0, 0, 0, 0, 0);
+		expected = strtol(getenv("SBI_IMPLID"), NULL, 0);
+
+		gen_report(&ret, expected);
+	}
+	report_prefix_pop();
+
 	report_prefix_push("probe_ext");
 	if (env_is_defined("PROBE_EXT")) {
 		expected = strtol(getenv("PROBE_EXT"), NULL, 0);