mbox series

[V4,0/6] Add riscv tests to cover the base extension specs

Message ID 20240313215106.325766-1-cem@kernel.org
Headers show
Series Add riscv tests to cover the base extension specs | expand

Message

Carlos Maiolino March 13, 2024, 9:50 p.m. UTC
From: Carlos Maiolino <cem@kernel.org>

Hi,

This is a new (V4) version of this series to create tests to cover functions
of the riscv's SBI base implementation spec. The series also includes a
a few helpers to reduce code duplication.

This new version includes updates related to Drew reviews, and rebasing of
the patches according to the changes. 
This new series has also been rebased on TOT, didn't affect the patches,
but worth the heads up.

Patches tagged with V4 needed modifications from the previous version.

Detailed updates are specified on a patch-basis


Carlos Maiolino (6):
  riscv: Add a wrapper to call sbi_ecall for base extension
  riscv: Add test to probe SBI Extension
  riscv: Factor out environment variable check and report generation
  riscv: Implement test for architecture ID register
  riscv: Enable gen_report() to print the wrong value in case of failure
  riscv: Test for specific SBI implementation ID

 riscv/sbi.c | 81 +++++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 69 insertions(+), 12 deletions(-)

Comments

Andrew Jones March 18, 2024, 5:24 p.m. UTC | #1
On Wed, Mar 13, 2024 at 10:50:51PM +0100, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Hi,
> 
> This is a new (V4) version of this series to create tests to cover functions
> of the riscv's SBI base implementation spec. The series also includes a
> a few helpers to reduce code duplication.
> 
> This new version includes updates related to Drew reviews, and rebasing of
> the patches according to the changes. 
> This new series has also been rebased on TOT, didn't affect the patches,
> but worth the heads up.
> 
> Patches tagged with V4 needed modifications from the previous version.
> 
> Detailed updates are specified on a patch-basis
> 
> 
> Carlos Maiolino (6):
>   riscv: Add a wrapper to call sbi_ecall for base extension
>   riscv: Add test to probe SBI Extension
>   riscv: Factor out environment variable check and report generation
>   riscv: Implement test for architecture ID register
>   riscv: Enable gen_report() to print the wrong value in case of failure
>   riscv: Test for specific SBI implementation ID
> 
>  riscv/sbi.c | 81 +++++++++++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 69 insertions(+), 12 deletions(-)
> 
> -- 
> 2.44.0
>

Merged to https://gitlab.com/kvm-unit-tests/kvm-unit-tests

Thanks,
drew
Andrew Jones March 18, 2024, 5:27 p.m. UTC | #2
On Mon, Mar 18, 2024 at 06:24:09PM +0100, Andrew Jones wrote:
> On Wed, Mar 13, 2024 at 10:50:51PM +0100, cem@kernel.org wrote:
> > From: Carlos Maiolino <cem@kernel.org>
> > 
> > Hi,
> > 
> > This is a new (V4) version of this series to create tests to cover functions
> > of the riscv's SBI base implementation spec. The series also includes a
> > a few helpers to reduce code duplication.
> > 
> > This new version includes updates related to Drew reviews, and rebasing of
> > the patches according to the changes. 
> > This new series has also been rebased on TOT, didn't affect the patches,
> > but worth the heads up.
> > 
> > Patches tagged with V4 needed modifications from the previous version.
> > 
> > Detailed updates are specified on a patch-basis
> > 
> > 
> > Carlos Maiolino (6):
> >   riscv: Add a wrapper to call sbi_ecall for base extension
> >   riscv: Add test to probe SBI Extension
> >   riscv: Factor out environment variable check and report generation
> >   riscv: Implement test for architecture ID register
> >   riscv: Enable gen_report() to print the wrong value in case of failure
> >   riscv: Test for specific SBI implementation ID
> > 
> >  riscv/sbi.c | 81 +++++++++++++++++++++++++++++++++++++++++++++--------
> >  1 file changed, 69 insertions(+), 12 deletions(-)
> > 
> > -- 
> > 2.44.0
> >
> 
> Merged to https://gitlab.com/kvm-unit-tests/kvm-unit-tests

Hi Carlos,

I just realized you've forgotten to CC tech-prs on v3 and v4.

drew
Carlos Maiolino March 18, 2024, 6:39 p.m. UTC | #3
On Mon, Mar 18, 2024 at 06:27:03PM +0100, Andrew Jones wrote:
> On Mon, Mar 18, 2024 at 06:24:09PM +0100, Andrew Jones wrote:
> > On Wed, Mar 13, 2024 at 10:50:51PM +0100, cem@kernel.org wrote:
> > > From: Carlos Maiolino <cem@kernel.org>
> > >
> > > Hi,
> > >
> > > This is a new (V4) version of this series to create tests to cover functions
> > > of the riscv's SBI base implementation spec. The series also includes a
> > > a few helpers to reduce code duplication.
> > >
> > > This new version includes updates related to Drew reviews, and rebasing of
> > > the patches according to the changes.
> > > This new series has also been rebased on TOT, didn't affect the patches,
> > > but worth the heads up.
> > >
> > > Patches tagged with V4 needed modifications from the previous version.
> > >
> > > Detailed updates are specified on a patch-basis
> > >
> > >
> > > Carlos Maiolino (6):
> > >   riscv: Add a wrapper to call sbi_ecall for base extension
> > >   riscv: Add test to probe SBI Extension
> > >   riscv: Factor out environment variable check and report generation
> > >   riscv: Implement test for architecture ID register
> > >   riscv: Enable gen_report() to print the wrong value in case of failure
> > >   riscv: Test for specific SBI implementation ID
> > >
> > >  riscv/sbi.c | 81 +++++++++++++++++++++++++++++++++++++++++++++--------
> > >  1 file changed, 69 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.44.0
> > >
> >
> > Merged to https://gitlab.com/kvm-unit-tests/kvm-unit-tests
> 
> Hi Carlos,
> 
> I just realized you've forgotten to CC tech-prs on v3 and v4.

I actually didn't CC them on purpose. The list seems to only accept incoming emails from registered
users, so all previous attempts I got a bunch of delivery failure messages, so I thought it was
pointless to CC them. I should get myself registered there, but I didn't have time so far to figure
it out. 

Carlos.

> 
> drew
Atish Patra March 18, 2024, 7:37 p.m. UTC | #4
On Mon, Mar 18, 2024 at 11:39 AM Carlos Maiolino <cem@kernel.org> wrote:
>
> On Mon, Mar 18, 2024 at 06:27:03PM +0100, Andrew Jones wrote:
> > On Mon, Mar 18, 2024 at 06:24:09PM +0100, Andrew Jones wrote:
> > > On Wed, Mar 13, 2024 at 10:50:51PM +0100, cem@kernel.org wrote:
> > > > From: Carlos Maiolino <cem@kernel.org>
> > > >
> > > > Hi,
> > > >
> > > > This is a new (V4) version of this series to create tests to cover functions
> > > > of the riscv's SBI base implementation spec. The series also includes a
> > > > a few helpers to reduce code duplication.
> > > >
> > > > This new version includes updates related to Drew reviews, and rebasing of
> > > > the patches according to the changes.
> > > > This new series has also been rebased on TOT, didn't affect the patches,
> > > > but worth the heads up.
> > > >
> > > > Patches tagged with V4 needed modifications from the previous version.
> > > >
> > > > Detailed updates are specified on a patch-basis
> > > >
> > > >
> > > > Carlos Maiolino (6):
> > > >   riscv: Add a wrapper to call sbi_ecall for base extension
> > > >   riscv: Add test to probe SBI Extension
> > > >   riscv: Factor out environment variable check and report generation
> > > >   riscv: Implement test for architecture ID register
> > > >   riscv: Enable gen_report() to print the wrong value in case of failure
> > > >   riscv: Test for specific SBI implementation ID
> > > >
> > > >  riscv/sbi.c | 81 +++++++++++++++++++++++++++++++++++++++++++++--------
> > > >  1 file changed, 69 insertions(+), 12 deletions(-)
> > > >
> > > > --
> > > > 2.44.0
> > > >
> > >
> > > Merged to https://gitlab.com/kvm-unit-tests/kvm-unit-tests
> >
> > Hi Carlos,
> >
> > I just realized you've forgotten to CC tech-prs on v3 and v4.
>
> I actually didn't CC them on purpose. The list seems to only accept incoming emails from registered
> users, so all previous attempts I got a bunch of delivery failure messages, so I thought it was
> pointless to CC them. I should get myself registered there, but I didn't have time so far to figure
> it out.
>
Here are the details.
https://lists.riscv.org/g/tech-prs

IIRC, you also need to be an individual member or employee of a RVI
member company to subscribe to PRS.

@Andrew Jones : I don't think it is possible for every contributor for
kvm-unit-tests to be a member of RVI
and subscribe to PRS.

Maybe we should just send periodic updates ? I am not sure if there is
a better way to do cross-posting.

> Carlos.
>
> >
> > drew
>
> --
> kvm-riscv mailing list
> kvm-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kvm-riscv
Andrew Jones March 19, 2024, 7:38 a.m. UTC | #5
On Mon, Mar 18, 2024 at 12:37:46PM -0700, Atish Patra wrote:
> On Mon, Mar 18, 2024 at 11:39 AM Carlos Maiolino <cem@kernel.org> wrote:
> >
> > On Mon, Mar 18, 2024 at 06:27:03PM +0100, Andrew Jones wrote:
> > > On Mon, Mar 18, 2024 at 06:24:09PM +0100, Andrew Jones wrote:
> > > > On Wed, Mar 13, 2024 at 10:50:51PM +0100, cem@kernel.org wrote:
> > > > > From: Carlos Maiolino <cem@kernel.org>
> > > > >
> > > > > Hi,
> > > > >
> > > > > This is a new (V4) version of this series to create tests to cover functions
> > > > > of the riscv's SBI base implementation spec. The series also includes a
> > > > > a few helpers to reduce code duplication.
> > > > >
> > > > > This new version includes updates related to Drew reviews, and rebasing of
> > > > > the patches according to the changes.
> > > > > This new series has also been rebased on TOT, didn't affect the patches,
> > > > > but worth the heads up.
> > > > >
> > > > > Patches tagged with V4 needed modifications from the previous version.
> > > > >
> > > > > Detailed updates are specified on a patch-basis
> > > > >
> > > > >
> > > > > Carlos Maiolino (6):
> > > > >   riscv: Add a wrapper to call sbi_ecall for base extension
> > > > >   riscv: Add test to probe SBI Extension
> > > > >   riscv: Factor out environment variable check and report generation
> > > > >   riscv: Implement test for architecture ID register
> > > > >   riscv: Enable gen_report() to print the wrong value in case of failure
> > > > >   riscv: Test for specific SBI implementation ID
> > > > >
> > > > >  riscv/sbi.c | 81 +++++++++++++++++++++++++++++++++++++++++++++--------
> > > > >  1 file changed, 69 insertions(+), 12 deletions(-)
> > > > >
> > > > > --
> > > > > 2.44.0
> > > > >
> > > >
> > > > Merged to https://gitlab.com/kvm-unit-tests/kvm-unit-tests
> > >
> > > Hi Carlos,
> > >
> > > I just realized you've forgotten to CC tech-prs on v3 and v4.
> >
> > I actually didn't CC them on purpose. The list seems to only accept incoming emails from registered
> > users, so all previous attempts I got a bunch of delivery failure messages, so I thought it was
> > pointless to CC them. I should get myself registered there, but I didn't have time so far to figure
> > it out.
> >
> Here are the details.
> https://lists.riscv.org/g/tech-prs
> 
> IIRC, you also need to be an individual member or employee of a RVI
> member company to subscribe to PRS.
> 
> @Andrew Jones : I don't think it is possible for every contributor for
> kvm-unit-tests to be a member of RVI
> and subscribe to PRS.
> 
> Maybe we should just send periodic updates ?

Periodic updates sounds good to me.

Thanks,
drew

> I am not sure if there is
> a better way to do cross-posting.
> 
> > Carlos.
> >
> > >
> > > drew
> >
> > --
> > kvm-riscv mailing list
> > kvm-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kvm-riscv
> 
> 
> 
> -- 
> Regards,
> Atish
Carlos Maiolino March 20, 2024, 8:16 a.m. UTC | #6
On Mon, Mar 18, 2024 at 12:37:46PM -0700, Atish Patra wrote:
> On Mon, Mar 18, 2024 at 11:39 AM Carlos Maiolino <cem@kernel.org> wrote:
> >
> > On Mon, Mar 18, 2024 at 06:27:03PM +0100, Andrew Jones wrote:
> > > On Mon, Mar 18, 2024 at 06:24:09PM +0100, Andrew Jones wrote:
> > > > On Wed, Mar 13, 2024 at 10:50:51PM +0100, cem@kernel.org wrote:
> > > > > From: Carlos Maiolino <cem@kernel.org>
> > > > >
> > > > > Hi,
> > > > >
> > > > > This is a new (V4) version of this series to create tests to cover functions
> > > > > of the riscv's SBI base implementation spec. The series also includes a
> > > > > a few helpers to reduce code duplication.
> > > > >
> > > > > This new version includes updates related to Drew reviews, and rebasing of
> > > > > the patches according to the changes.
> > > > > This new series has also been rebased on TOT, didn't affect the patches,
> > > > > but worth the heads up.
> > > > >
> > > > > Patches tagged with V4 needed modifications from the previous version.
> > > > >
> > > > > Detailed updates are specified on a patch-basis
> > > > >
> > > > >
> > > > > Carlos Maiolino (6):
> > > > >   riscv: Add a wrapper to call sbi_ecall for base extension
> > > > >   riscv: Add test to probe SBI Extension
> > > > >   riscv: Factor out environment variable check and report generation
> > > > >   riscv: Implement test for architecture ID register
> > > > >   riscv: Enable gen_report() to print the wrong value in case of failure
> > > > >   riscv: Test for specific SBI implementation ID
> > > > >
> > > > >  riscv/sbi.c | 81 +++++++++++++++++++++++++++++++++++++++++++++--------
> > > > >  1 file changed, 69 insertions(+), 12 deletions(-)
> > > > >
> > > > > --
> > > > > 2.44.0
> > > > >
> > > >
> > > > Merged to https://gitlab.com/kvm-unit-tests/kvm-unit-tests
> > >
> > > Hi Carlos,
> > >
> > > I just realized you've forgotten to CC tech-prs on v3 and v4.
> >
> > I actually didn't CC them on purpose. The list seems to only accept incoming emails from registered
> > users, so all previous attempts I got a bunch of delivery failure messages, so I thought it was
> > pointless to CC them. I should get myself registered there, but I didn't have time so far to figure
> > it out.
> >
> Here are the details.
> https://lists.riscv.org/g/tech-prs

Thanks for the link, I'll look into that.

> 
> IIRC, you also need to be an individual member or employee of a RVI
> member company to subscribe to PRS.
> 
> @Andrew Jones : I don't think it is possible for every contributor for
> kvm-unit-tests to be a member of RVI
> and subscribe to PRS.
> 
> Maybe we should just send periodic updates ? I am not sure if there is
> a better way to do cross-posting.
> 
> > Carlos.
> >
> > >
> > > drew
> >
> > --
> > kvm-riscv mailing list
> > kvm-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kvm-riscv
> 
> 
> 
> --
> Regards,
> Atish