diff mbox series

[14/17] tests: ap_pmf: wait for STA appropriately

Message ID 20230925092039.2968df905e62.Icde7152da27a92c36e1e85043b8145168086b2c2@changeid
State Accepted
Headers show
Series tests: some scheduling and other fixes | expand

Commit Message

Johannes Berg Sept. 25, 2023, 7:20 a.m. UTC 
From: Johannes Berg <johannes.berg@intel.com>

With PMF, we cannot do even deauth unless we wait
for the STA to have fully connected on the AP side,
the STA thinking it has isn't sufficient since it
immediately says so after M4. Add wait_sta() before
disconnect, and also before SA_QUERY.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 tests/hwsim/test_ap_pmf.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/tests/hwsim/test_ap_pmf.py b/tests/hwsim/test_ap_pmf.py
index fe0955ba2539..e0b5b5782fc8 100644
--- a/tests/hwsim/test_ap_pmf.py
+++ b/tests/hwsim/test_ap_pmf.py
@@ -87,7 +87,7 @@  def test_ocv_sa_query(dev, apdev):
     dev[0].connect(ssid, psk="12345678", ieee80211w="1", ocv="1",
                    key_mgmt="WPA-PSK WPA-PSK-SHA256", proto="WPA2",
                    scan_freq="2412")
-
+    hapd.wait_sta() # wait so we can actually request SA_QUERY
     # Test that client can handle SA Query with OCI element
     if "OK" not in hapd.request("SA_QUERY " + dev[0].own_addr()):
         raise Exception("SA_QUERY failed")
@@ -144,7 +144,7 @@  def test_ocv_sa_query_csa_missing(dev, apdev):
     dev[0].connect(ssid, psk="12345678", ieee80211w="1", ocv="1",
                    key_mgmt="WPA-PSK WPA-PSK-SHA256", proto="WPA2",
                    scan_freq="2412")
-
+    hapd.wait_sta() # wait so kernel won't drop deauth frame (MFP)
     hapd.set("ext_mgmt_frame_handling", "1")
     dev[0].request("DISCONNECT")
     dev[0].wait_disconnected()