diff mbox

Library directories for tilegx

Message ID alpine.DEB.2.20.1611041332300.1065@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Nov. 4, 2016, 1:32 p.m. UTC 
On Thu, 3 Nov 2016, Chris Metcalf wrote:

> On 11/3/2016 7:08 PM, Joseph Myers wrote:
> > Incidentally, I found another issue in building: GCC has a tilegxbe-*
> > target name for big-endian, but sysdeps/tile/preconfigure only handles
> > tilegx, not tilegxbe.  However, that's easy to work around by configuring
> > glibc for a different triplet from GCC.
> 
> Good point.  I don't actually test tilegxbe; I don't think we ever had a lot
> of interest in that version of the toolchain.  I will try to remember to add
> it next time I do tests, and I can push up a fix to preconfigure at that point
> too (or feel free to push one yourself).

Fix pushed thus.

Handle tilegx* machine names.

This patch makes sysdeps/tile/preconfigure handle tilegx* machine
names instead of just plain tilegx.  That matches GCC, and in
particular allows a big-endian toolchain to use the tilegxbe-linux-gnu
name when configuring both GCC and glibc.

Tested with compilation for tilegxbe-linux-gnu, both 32-bit and 64-bit
(building a subsequent GCC against that glibc still falls over because
of both 32-bit and 64-bit libraries going in the lib directory, as
noted at
<https://sourceware.org/ml/libc-alpha/2016-11/msg00129.html>).

2016-11-04  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/tile/preconfigure: Accept tilegx* instead of tilegx.

Comments

Chris Metcalf Nov. 4, 2016, 3:11 p.m. UTC | #1 
On 11/4/2016 7:32 AM, Joseph Myers wrote:
> On Thu, 3 Nov 2016, Chris Metcalf wrote:
>
>> On 11/3/2016 7:08 PM, Joseph Myers wrote:
>>> Incidentally, I found another issue in building: GCC has a tilegxbe-*
>>> target name for big-endian, but sysdeps/tile/preconfigure only handles
>>> tilegx, not tilegxbe.  However, that's easy to work around by configuring
>>> glibc for a different triplet from GCC.
>> Good point.  I don't actually test tilegxbe; I don't think we ever had a lot
>> of interest in that version of the toolchain.  I will try to remember to add
>> it next time I do tests, and I can push up a fix to preconfigure at that point
>> too (or feel free to push one yourself).
> Fix pushed thus.

Thanks, looks good.
diff mbox

Patch

diff --git a/sysdeps/tile/preconfigure b/sysdeps/tile/preconfigure
index dfe050c..f3e5d7e 100644
--- a/sysdeps/tile/preconfigure
+++ b/sysdeps/tile/preconfigure
@@ -2,7 +2,7 @@ 
 case "$machine" in
     tilepro)
 	base_machine=tile machine=tile/tilepro ;;
-    tilegx)
+    tilegx*)
 	base_machine=tile
 	if $CC $CFLAGS $CPPFLAGS -E -dM -xc /dev/null | grep -q __LP64__; then
 	    machine=tile/tilegx/tilegx64