From patchwork Fri Nov 4 13:32:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 691267 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3t9N8536gtz9vDw for ; Sat, 5 Nov 2016 00:33:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="U+cN6wBP"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=fd2OE mDl48fAEy31FWIWzsmrMvhrl5sRpx8S8uKtCYXGREwp+2IdggszPRQ0AZTRy/Img UNTmpRVD90ONTmosnnjmqK4kpyrt0YQT1Lcd5pxhyoPq/qGv2pIcXMrscvix2FN2 7BgdGO4srQjZy/17jMKu+0Ket9dwoWbkIsR/WU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=zzsast5zzFf KVun6qXK5DPfYRw4=; b=U+cN6wBPgQIPFh3XHNLJsSIYK1tiumcK1FHiAVr1ym6 W5ycMEvAY1SYJ109XfzOTm0oSfO1NVkdrsZuDUzvXEloKHY3eBroOI9Ph9stKi1o nK5QjAXwtKsSLha/zb1kKRyXsDMGNCR4I1pom5eTprvAV6EH1/ilcOCTTeobW4ks = Received: (qmail 128237 invoked by alias); 4 Nov 2016 13:33:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 128187 invoked by uid 89); 4 Nov 2016 13:33:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=$CC, $cc, interest X-HELO: relay1.mentorg.com Date: Fri, 4 Nov 2016 13:32:58 +0000 From: Joseph Myers To: Chris Metcalf CC: Subject: Re: Library directories for tilegx In-Reply-To: <691b37f4-437f-67b5-5a0c-d5ce31ea1604@mellanox.com> Message-ID: References: <1e1c3a65-b62f-7736-3fb8-741aa6afe09f@mellanox.com> <691b37f4-437f-67b5-5a0c-d5ce31ea1604@mellanox.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) On Thu, 3 Nov 2016, Chris Metcalf wrote: > On 11/3/2016 7:08 PM, Joseph Myers wrote: > > Incidentally, I found another issue in building: GCC has a tilegxbe-* > > target name for big-endian, but sysdeps/tile/preconfigure only handles > > tilegx, not tilegxbe. However, that's easy to work around by configuring > > glibc for a different triplet from GCC. > > Good point. I don't actually test tilegxbe; I don't think we ever had a lot > of interest in that version of the toolchain. I will try to remember to add > it next time I do tests, and I can push up a fix to preconfigure at that point > too (or feel free to push one yourself). Fix pushed thus. Handle tilegx* machine names. This patch makes sysdeps/tile/preconfigure handle tilegx* machine names instead of just plain tilegx. That matches GCC, and in particular allows a big-endian toolchain to use the tilegxbe-linux-gnu name when configuring both GCC and glibc. Tested with compilation for tilegxbe-linux-gnu, both 32-bit and 64-bit (building a subsequent GCC against that glibc still falls over because of both 32-bit and 64-bit libraries going in the lib directory, as noted at ). 2016-11-04 Joseph Myers * sysdeps/tile/preconfigure: Accept tilegx* instead of tilegx. diff --git a/sysdeps/tile/preconfigure b/sysdeps/tile/preconfigure index dfe050c..f3e5d7e 100644 --- a/sysdeps/tile/preconfigure +++ b/sysdeps/tile/preconfigure @@ -2,7 +2,7 @@ case "$machine" in tilepro) base_machine=tile machine=tile/tilepro ;; - tilegx) + tilegx*) base_machine=tile if $CC $CFLAGS $CPPFLAGS -E -dM -xc /dev/null | grep -q __LP64__; then machine=tile/tilegx/tilegx64