| Message ID | yddedagw4q4.fsf_-_@CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: c++: Skip g++.dg/analyzer on Solaris [PR111475] | expand |
On Sun, 5 May 2024, Rainer Orth wrote: > Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes: > > >> On Fri, May 03, 2024 at 09:31:08AM -0400, David Malcolm wrote: > >>> Jakub, Richi, Rainer: this is a non-trivial change that cleans up > >>> analyzer C++ testsuite results on Solaris, but has a slight risk of > >>> affecting analyzer behavior on other targets. As such, I was thinking > >>> to hold off on backporting it to GCC 14 until after 14.1 is released. > >>> Is that a good plan? > >> > >> Agreed 14.2 is better target than 14.1 for this, especially if committed > >> shortly after 14.1 goes out. > > > > fully agreed: this is way too risky this close to the 14.1 release. As > > a stop-gap measure, one might consider just skipping the C++ analyzer > > tests on Solaris to avoid the immense number of testsuite failures. > > How about this? > > Almost 1400 C++ analyzer tests FAIL on Solaris. The patch is too risky > to apply so close to the GCC 14.1.0 release, so disable the tests on > Solaris instead to reduce the noise. > > Tested on i386-pc-solaris2.11, sparc-sun-solaris2.11, and > x86_64-pc-linux-gnu. > > Ok for gcc-14 branch? OK. Richard.
diff --git a/gcc/testsuite/g++.dg/analyzer/analyzer.exp b/gcc/testsuite/g++.dg/analyzer/analyzer.exp --- a/gcc/testsuite/g++.dg/analyzer/analyzer.exp +++ b/gcc/testsuite/g++.dg/analyzer/analyzer.exp @@ -24,6 +24,11 @@ if { ![check_effective_target_analyzer] return } +# Disable on Solaris until PR analyzer/111475 is fixed. +if { [istarget *-*-solaris2.*] } { + return +} + if [info exists DEFAULT_CXXFLAGS] then { set save_default_cxxflags $DEFAULT_CXXFLAGS }