From patchwork Sun May 5 17:25:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 1931587 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=ekv36BGs; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VXWfP1JWMz1yZk for ; Mon, 6 May 2024 03:26:03 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A5FD3858C35 for ; Sun, 5 May 2024 17:26:02 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id A6B043858D28; Sun, 5 May 2024 17:25:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6B043858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A6B043858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714929943; cv=none; b=pKYcvIJL3MyNCDo45iFuH7utxC7kUuoqk2y6ectUzS0qSqxd05wh6ImZBEedoIMARS/vEviHcX/YoxeJnr1PmlYUcqf4vfRkxGRcVdovGerp1tebNYLA9iBT0Es8IjYrsFAZF5WjycTqg6/+gaT6Sp89IS+olQbjPPsDv2PC5oU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714929943; c=relaxed/simple; bh=2slage98nYk/YfPUccnCDLX2qENenUXeg78hXeDXW5w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cQ9UTRkkgf3KsqYuJlfGn49TAg3mkI/SRwQZ6dsZQBypuWRY8SaKDOV13fRFVNiQeLuykHVvofI3z/k7z+vjJAd3ygLpLYKSbDNcDsKOE6Pf6Wqw0D6oqz1cZkFhYb9zsx4wKT2U9yPoTx3kyI97Ei0BARHtfWyU+/Z913Ua9sU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 9FB1CB7C20; Sun, 5 May 2024 19:25:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-type:content-type :mime-version:user-agent:message-id:in-reply-to:date:date :references:subject:subject:from:from:received:received; s= 20200306; t=1714929940; bh=2slage98nYk/YfPUccnCDLX2qENenUXeg78hX eDXW5w=; b=ekv36BGst+xBdfGrQ38ai0RTndRsmdvE4vetRH/VMVbGNcm4XCxKB NYPULeg5NQWF0X2xRmDe7iQwKXBTi1QEsdBaDpxUYXRXqBNoLYjjSPlIUd2DQiNu V5CJl1e8iL8YXKCGxUcgl6NZ7ThVNVoIlGRkoHbb0/RQP65IfqPtHhbF3uFuvGGr UpB01EWCba+8XBYvtXecCDhTOz8xV8mygPfPVgjg5MHaHYPzS2h4DbyW2uPowRD7 01gSsi9tclkOLMXTXVK3M3hncQftX0Vxx6Bo4bMwDkL25BUAFMzati3iyGYMjy2r CcraJLrvdjX0NsEh0X9aRn5bMx/14gKdw== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HwlnGuxUADJ1; Sun, 5 May 2024 19:25:40 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p5085529e.dip0.t-ipconnect.de [80.133.82.158]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id D1066B79E1; Sun, 5 May 2024 19:25:39 +0200 (CEST) From: Rainer Orth To: Jakub Jelinek Cc: David Malcolm , gcc-patches@gcc.gnu.org, Richard Biener , ro@gcc.gnu.org Subject: [PATCH] testsuite: c++: Skip g++.dg/analyzer on Solaris [PR111475] References: <20240503133108.1838654-1-dmalcolm@redhat.com> Date: Sun, 05 May 2024 19:25:39 +0200 In-Reply-To: (Rainer Orth's message of "Fri, 03 May 2024 15:51:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 X-Spam-Status: No, score=-3790.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Rainer Orth writes: >> On Fri, May 03, 2024 at 09:31:08AM -0400, David Malcolm wrote: >>> Jakub, Richi, Rainer: this is a non-trivial change that cleans up >>> analyzer C++ testsuite results on Solaris, but has a slight risk of >>> affecting analyzer behavior on other targets. As such, I was thinking >>> to hold off on backporting it to GCC 14 until after 14.1 is released. >>> Is that a good plan? >> >> Agreed 14.2 is better target than 14.1 for this, especially if committed >> shortly after 14.1 goes out. > > fully agreed: this is way too risky this close to the 14.1 release. As > a stop-gap measure, one might consider just skipping the C++ analyzer > tests on Solaris to avoid the immense number of testsuite failures. How about this? Almost 1400 C++ analyzer tests FAIL on Solaris. The patch is too risky to apply so close to the GCC 14.1.0 release, so disable the tests on Solaris instead to reduce the noise. Tested on i386-pc-solaris2.11, sparc-sun-solaris2.11, and x86_64-pc-linux-gnu. Ok for gcc-14 branch? Rainer diff --git a/gcc/testsuite/g++.dg/analyzer/analyzer.exp b/gcc/testsuite/g++.dg/analyzer/analyzer.exp --- a/gcc/testsuite/g++.dg/analyzer/analyzer.exp +++ b/gcc/testsuite/g++.dg/analyzer/analyzer.exp @@ -24,6 +24,11 @@ if { ![check_effective_target_analyzer] return } +# Disable on Solaris until PR analyzer/111475 is fixed. +if { [istarget *-*-solaris2.*] } { + return +} + if [info exists DEFAULT_CXXFLAGS] then { set save_default_cxxflags $DEFAULT_CXXFLAGS }