| Message ID | SJ2PR01MB8193FE48847E289D12C76171E8EB2@SJ2PR01MB8193.prod.exchangelabs.com |
|---|---|
| State | New |
| Headers | show |
| Series | [tree-optimization/110279] fix testcase pr110279-1.c | expand |
On 5/22/24 5:46 AM, Di Zhao OS wrote: > The test case is for targets that support FMA. Previously > the "target" selector is missed in dg-final command. > > Tested on x86_64-pc-linux-gnu. > > Thanks > Di Zhao > > gcc/testsuite/ChangeLog: > > * gcc.dg/pr110279-1.c: add target selector. Rather than list targets explicitly in the test, wouldn't it be better to have a common routine that could be used in other cases where we have a test that requires FMA? So something similar to check_effective_target_scalar_all_fma? JEff
> -----Original Message----- > From: Jeff Law <jeffreyalaw@gmail.com> > Sent: Wednesday, May 22, 2024 11:14 PM > To: Di Zhao OS <dizhao@os.amperecomputing.com>; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] [tree-optimization/110279] fix testcase pr110279-1.c > > > > On 5/22/24 5:46 AM, Di Zhao OS wrote: > > The test case is for targets that support FMA. Previously > > the "target" selector is missed in dg-final command. > > > > Tested on x86_64-pc-linux-gnu. > > > > Thanks > > Di Zhao > > > > gcc/testsuite/ChangeLog: > > > > * gcc.dg/pr110279-1.c: add target selector. > Rather than list targets explicitly in the test, wouldn't it be better > to have a common routine that could be used in other cases where we have > a test that requires FMA? > > So something similar to check_effective_target_scalar_all_fma? > > > Jeff Here is an updated version of the patch. Sorry I'm not very familiar with the testsuite commands. gcc/testsuite/ChangeLog: * gcc.dg/pr110279-1.c: add target selector. --- gcc/testsuite/gcc.dg/pr110279-1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.dg/pr110279-1.c b/gcc/testsuite/gcc.dg/pr110279-1.c index a8c7257b28d..c4f94ea5810 100644 --- a/gcc/testsuite/gcc.dg/pr110279-1.c +++ b/gcc/testsuite/gcc.dg/pr110279-1.c @@ -1,4 +1,4 @@ -/* { dg-do compile } */ +/* { dg-do compile { target { scalar_all_fma || { i?86-*-* x86_64-*-* } } } } */ /* { dg-options "-Ofast --param avoid-fma-max-bits=512 --param tree-reassoc-width=4 -fdump-tree-widening_mul-details" } */ /* { dg-additional-options "-mcpu=generic" { target aarch64*-*-* } } */ /* { dg-additional-options "-mfma" { target i?86-*-* x86_64-*-* } } */ @@ -64,4 +64,4 @@ foo3 (data_e a, data_e b, data_e c, data_e d) return result; } -/* { dg-final { scan-tree-dump-times "Generated FMA" 3 "widening_mul"} } */ \ No newline at end of file +/* { dg-final { scan-tree-dump-times "Generated FMA" 3 "widening_mul" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110279-1.c b/gcc/testsuite/gcc.dg/pr110279-1.c index a8c7257b28d..5436163bc78 100644 --- a/gcc/testsuite/gcc.dg/pr110279-1.c +++ b/gcc/testsuite/gcc.dg/pr110279-1.c @@ -64,4 +64,4 @@ foo3 (data_e a, data_e b, data_e c, data_e d) return result; } -/* { dg-final { scan-tree-dump-times "Generated FMA" 3 "widening_mul"} } */ \ No newline at end of file +/* { dg-final { scan-tree-dump-times "Generated FMA" 3 "widening_mul" { target { { i?86-*-* x86_64-*-* } || { aarch64*-*-* } } } } } */
The test case is for targets that support FMA. Previously the "target" selector is missed in dg-final command. Tested on x86_64-pc-linux-gnu. Thanks Di Zhao gcc/testsuite/ChangeLog: * gcc.dg/pr110279-1.c: add target selector. --- gcc/testsuite/gcc.dg/pr110279-1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)