| Message ID | 79e96909-5e54-316f-fb8a-9954ea4c6460@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | Remove legacy external declarations in toplev.h [PR101447] | expand |
On Thu, Jul 15, 2021 at 3:54 AM ashimida via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > > External declarations in ./gcc/toplev.h is no longer used in newest > version of gcc and should be cleaned up to avoid misunderstandings. OK > gcc/ChangeLog: > > * toplev.h (set_random_seed): > > --- > diff --git a/gcc/toplev.h b/gcc/toplev.h > index 175944c..f543554 100644 > --- a/gcc/toplev.h > +++ b/gcc/toplev.h > @@ -94,11 +94,6 @@ extern bool set_src_pwd (const > char *); > extern HOST_WIDE_INT get_random_seed (bool); > extern void set_random_seed (const char *); > > -extern unsigned int min_align_loops_log; > -extern unsigned int min_align_jumps_log; > -extern unsigned int min_align_labels_log; > -extern unsigned int min_align_functions_log; > - > extern void parse_alignment_opts (void); > > extern void initialize_rtl (void); > > --- > The history FYI: > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e6de53356769e13178975c18b4ce019a800ea946;hp=118f2d8bc3e6804996ca2953b86454ec950054bf >
On 7/15/2021 1:58 AM, Richard Biener via Gcc-patches wrote: > On Thu, Jul 15, 2021 at 3:54 AM ashimida via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: >> >> External declarations in ./gcc/toplev.h is no longer used in newest >> version of gcc and should be cleaned up to avoid misunderstandings. > OK > >> gcc/ChangeLog: >> >> * toplev.h (set_random_seed): I've fixed the ChangeLog and committed this to the trunk for Ashimida. Ashimida -- in the future please don't close the PR until the change has been committed to the trunk. Thanks, Jeff
diff --git a/gcc/toplev.h b/gcc/toplev.h index 175944c..f543554 100644 --- a/gcc/toplev.h +++ b/gcc/toplev.h @@ -94,11 +94,6 @@ extern bool set_src_pwd (const char *); extern HOST_WIDE_INT get_random_seed (bool); extern void set_random_seed (const char *); -extern unsigned int min_align_loops_log; -extern unsigned int min_align_jumps_log; -extern unsigned int min_align_labels_log; -extern unsigned int min_align_functions_log; - extern void parse_alignment_opts (void);
External declarations in ./gcc/toplev.h is no longer used in newest version of gcc and should be cleaned up to avoid misunderstandings. gcc/ChangeLog: * toplev.h (set_random_seed): --- extern void initialize_rtl (void); --- The history FYI: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e6de53356769e13178975c18b4ce019a800ea946;hp=118f2d8bc3e6804996ca2953b86454ec950054bf