diff mbox

[PING] ICE with combination of -fopenmp and -femit-struct-debug-reduced/baseonly

Message ID 523981AF.9080102@arm.com
State New
Headers show

Commit Message

Kyrylo Tkachov Sept. 18, 2013, 10:34 a.m. UTC 
Hi Cary, Evgeny
On 13/09/13 23:38, Cary Coutant wrote:
>> I’ve attached fix for this issue:
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57737
>> There are fix, two tests and change log message.
>>
>> Is it ok?
>>
>> Cary, can you commit it for me?
>>
>> Ping this patch, http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00053.html
> Thanks for the fix, and sorry for the delay! I've committed it for you
> at r202582.
The tests should be guarded to not run on targets
  that don't support openmp, such as bare metal targets.

This patch adds an effective target check for openmp.

Ok to apply?

Thanks,
Kyrill

>
> -cary
>
>
> 2013-09-13  Evgeny Gavrin <e.gavrin@samsung.com>
>
> gcc/
>          * dwarf2out.c (should_emit_struct_debug): Add check
>          for type_decl variable is not NULL.
>
> gcc/testsuite
>          * gcc.dg/debug/dwarf2/omp-fesdr.c: Add test.
>          * g++.dg/debug/dwarf2/omp-fesdr.C: Add test.
>

Comments

Jakub Jelinek Sept. 18, 2013, 10:39 a.m. UTC | #1 
On Wed, Sep 18, 2013 at 11:34:23AM +0100, Kyrill Tkachov wrote:
> Hi Cary, Evgeny
> On 13/09/13 23:38, Cary Coutant wrote:
> >>I’ve attached fix for this issue:
> >>http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57737
> >>There are fix, two tests and change log message.
> >>
> >>Is it ok?
> >>
> >>Cary, can you commit it for me?
> >>
> >>Ping this patch, http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00053.html
> >Thanks for the fix, and sorry for the delay! I've committed it for you
> >at r202582.
> The tests should be guarded to not run on targets
>  that don't support openmp, such as bare metal targets.
> 
> This patch adds an effective target check for openmp.
> 
> Ok to apply?

Yes, with appropriate ChangeLog entry.

> --- a/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C
> +++ b/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target fopenmp } */
>  /* { dg-options "-g -fopenmp -gdwarf-2 -femit-struct-debug-reduced" } */
>  
>  struct aa
> diff --git a/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c b/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
> index 005acdf..d7b0319 100644
> --- a/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
> +++ b/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target fopenmp }  */
>  /* { dg-options "-g -fopenmp -gdwarf-2 -femit-struct-debug-reduced" } */
>  
>  struct aa

	Jakub
diff mbox

Patch

diff --git a/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C b/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C
index 005acdf..b3b65e9 100644
--- a/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C
+++ b/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C
@@ -1,4 +1,5 @@ 
 /* { dg-do compile } */
+/* { dg-require-effective-target fopenmp } */
 /* { dg-options "-g -fopenmp -gdwarf-2 -femit-struct-debug-reduced" } */
 
 struct aa
diff --git a/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c b/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
index 005acdf..d7b0319 100644
--- a/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
+++ b/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
@@ -1,4 +1,5 @@ 
 /* { dg-do compile } */
+/* { dg-require-effective-target fopenmp }  */
 /* { dg-options "-g -fopenmp -gdwarf-2 -femit-struct-debug-reduced" } */
 
 struct aa