From patchwork Wed Sep 18 10:34:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 275664 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 83E402C00D5 for ; Wed, 18 Sep 2013 20:34:55 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=QIM6iiOSPu96TjXGg wwCzqI+h9l0cEbPJEHcpqgFwxMIwdNLiXKU83foZPKjn4ck9dTyqO7OUoWXbOuAs O4dbzy10HIGLNUQrPggdsSrUfZhB54TQUrM+nO7rvxMSi5M5zmEwx81naNbVOMDA aZJkBUONpUqwbEnftekg+qf4UQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=JzT6ebb5TOSJ2YlQ6A4pLxV tUg8=; b=I4k7vM1tz2TnsoD71UVIlpsitBXUWFoiNVt5j9CdqT8up8Dap/1mJLO 529ECRDfYaqcJZQCA74imRq7dVpSzdqlZyOKMLEGPujUaoFyRJSin+WlXjEqIsCe uZ4+Xe78piYkMetp3XUX8lEcWcBx3jGd9j48iqOM6phAavemn4T4= Received: (qmail 4418 invoked by alias); 18 Sep 2013 10:34:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 4341 invoked by uid 89); 18 Sep 2013 10:34:29 -0000 Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2013 10:34:29 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_NO, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 18 Sep 2013 11:34:25 +0100 Received: from [10.1.208.24] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 18 Sep 2013 11:34:23 +0100 Message-ID: <523981AF.9080102@arm.com> Date: Wed, 18 Sep 2013 11:34:23 +0100 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: Cary Coutant CC: Evgeny Gavrin , gcc-patches , GarbuzovViacheslav Subject: Re: [PING][PATCH] ICE with combination of -fopenmp and -femit-struct-debug-reduced/baseonly References: <000a01ceafb1$85e48020$91ad8060$%gavrin@samsung.com> In-Reply-To: X-MC-Unique: 113091811342500501 X-IsSubscribed: yes Hi Cary, Evgeny On 13/09/13 23:38, Cary Coutant wrote: >> I’ve attached fix for this issue: >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57737 >> There are fix, two tests and change log message. >> >> Is it ok? >> >> Cary, can you commit it for me? >> >> Ping this patch, http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00053.html > Thanks for the fix, and sorry for the delay! I've committed it for you > at r202582. The tests should be guarded to not run on targets that don't support openmp, such as bare metal targets. This patch adds an effective target check for openmp. Ok to apply? Thanks, Kyrill > > -cary > > > 2013-09-13 Evgeny Gavrin > > gcc/ > * dwarf2out.c (should_emit_struct_debug): Add check > for type_decl variable is not NULL. > > gcc/testsuite > * gcc.dg/debug/dwarf2/omp-fesdr.c: Add test. > * g++.dg/debug/dwarf2/omp-fesdr.C: Add test. > diff --git a/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C b/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C index 005acdf..b3b65e9 100644 --- a/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C +++ b/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target fopenmp } */ /* { dg-options "-g -fopenmp -gdwarf-2 -femit-struct-debug-reduced" } */ struct aa diff --git a/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c b/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c index 005acdf..d7b0319 100644 --- a/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c +++ b/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target fopenmp } */ /* { dg-options "-g -fopenmp -gdwarf-2 -femit-struct-debug-reduced" } */ struct aa