diff mbox series

[5/8] testsuite/arm: Add arm_hard_ok check in armv8_2-fp16-scalar-2.c

Message ID 1616509970-26398-6-git-send-email-christophe.lyon@linaro.org
State New
Headers show
Series testsuite/arm: Various cleanups | expand

Commit Message

Christophe Lyon March 23, 2021, 2:32 p.m. UTC 
This test relies on -mfloat-abi=hard to pass (otherwise
test_mov_imm_[12] directly build the 1.0 fp16 representation via movw
r0, #15360 rather than using vmov.f16 s0, #1.0e+0 as expected by
scan-assembler-times)

Adding the arm_hard_ok check makes the test unsupported eg. on
arm-linux-gnueabi instead of reporting a failure.

2021-03-20  Christophe Lyon  <christophe.lyon@linaro.org>

	gcc/testsuite/
	* gcc.target/arm/armv8_2-fp16-scalar-2.c: Add arm_hard_ok.
---
 gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kyrylo Tkachov March 23, 2021, 2:56 p.m. UTC | #1 
> -----Original Message-----
> From: Gcc-patches <gcc-patches-bounces@gcc.gnu.org> On Behalf Of
> Christophe Lyon via Gcc-patches
> Sent: 23 March 2021 14:33
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH 5/8] testsuite/arm: Add arm_hard_ok check in armv8_2-
> fp16-scalar-2.c
> 
> This test relies on -mfloat-abi=hard to pass (otherwise
> test_mov_imm_[12] directly build the 1.0 fp16 representation via movw
> r0, #15360 rather than using vmov.f16 s0, #1.0e+0 as expected by
> scan-assembler-times)
> 
> Adding the arm_hard_ok check makes the test unsupported eg. on
> arm-linux-gnueabi instead of reporting a failure.

Ok.
Thanks,
Kyrill

> 
> 2021-03-20  Christophe Lyon  <christophe.lyon@linaro.org>
> 
> 	gcc/testsuite/
> 	* gcc.target/arm/armv8_2-fp16-scalar-2.c: Add arm_hard_ok.
> ---
>  gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c
> b/gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c
> index fa4828d..de5adf3 100644
> --- a/gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c
> +++ b/gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c
> @@ -1,7 +1,9 @@
>  /* { dg-do compile }  */
> +/* { dg-require-effective-target arm_hard_ok }  */
>  /* { dg-require-effective-target arm_v8_2a_fp16_scalar_ok }  */
>  /* { dg-options "-O2 -std=c11" }  */
>  /* { dg-add-options arm_v8_2a_fp16_scalar }  */
> +/* { dg-additional-options "-mfloat-abi=hard" } */
> 
>  /* Test compiler use of FP16 instructions.  */
>  #include <arm_fp16.h>
> --
> 2.7.4
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c b/gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c
index fa4828d..de5adf3 100644
--- a/gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c
+++ b/gcc/testsuite/gcc.target/arm/armv8_2-fp16-scalar-2.c
@@ -1,7 +1,9 @@ 
 /* { dg-do compile }  */
+/* { dg-require-effective-target arm_hard_ok }  */
 /* { dg-require-effective-target arm_v8_2a_fp16_scalar_ok }  */
 /* { dg-options "-O2 -std=c11" }  */
 /* { dg-add-options arm_v8_2a_fp16_scalar }  */
+/* { dg-additional-options "-mfloat-abi=hard" } */
 
 /* Test compiler use of FP16 instructions.  */
 #include <arm_fp16.h>