| Message ID | cover.1700473918.git.fweimer@redhat.com |
|---|---|
| Headers | show |
| Series | : More warnings as errors by default | expand |
On 11/20/23 02:55, Florian Weimer wrote: > This revision addresses Marek's comment about handing > -Wdeclaration-missing-parameter-type properly in conjunction with > -fpermissive. A new test (permerror-fpermissive-nowarning.c) > demonstrates the expected behavior. I added a test for -std=gnu89 > -fno-permissive, too. > > I'm including the precursor cleanup patches in this posting. Hopefully > this will make the aarch64 tester happy. > > Thanks, > Florian > > Florian Weimer (11): > aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder > aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c > gm2: Add missing declaration of m2pim_M2RTS_Terminate to test > Add tests for validating future C permerrors > c: Turn int-conversion warnings into permerrors > c: Turn -Wimplicit-function-declaration into a permerror > c: Turn -Wimplicit-int into a permerror > c: Do not ignore some forms of -Wimplicit-int in system headers > c: Turn -Wreturn-mismatch into a permerror > c: Turn -Wincompatible-pointer-types into a permerror > c: Add new -Wdeclaration-missing-parameter-type permerror The series is fine by me. But give Marek additional time to chime in, particularly given the holidays this week in the US. Say through this time next week? jeff
* Jeff Law: > On 11/20/23 02:55, Florian Weimer wrote: >> This revision addresses Marek's comment about handing >> -Wdeclaration-missing-parameter-type properly in conjunction with >> -fpermissive. A new test (permerror-fpermissive-nowarning.c) >> demonstrates the expected behavior. I added a test for -std=gnu89 >> -fno-permissive, too. >> I'm including the precursor cleanup patches in this posting. >> Hopefully >> this will make the aarch64 tester happy. >> Thanks, >> Florian >> Florian Weimer (11): >> aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder >> aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c >> gm2: Add missing declaration of m2pim_M2RTS_Terminate to test >> Add tests for validating future C permerrors >> c: Turn int-conversion warnings into permerrors >> c: Turn -Wimplicit-function-declaration into a permerror >> c: Turn -Wimplicit-int into a permerror >> c: Do not ignore some forms of -Wimplicit-int in system headers >> c: Turn -Wreturn-mismatch into a permerror >> c: Turn -Wincompatible-pointer-types into a permerror >> c: Add new -Wdeclaration-missing-parameter-type permerror > The series is fine by me. Thanks. > But give Marek additional time to chime in, particularly given the > holidays this week in the US. Say through this time next week? Yes, Marek and I spoke about it today. I'll wait a bit longer for feedback. I'm also gathering some numbers regarding autoconf impact and potential silent miscompilation. Thanks, Florian
Florian Weimer <fweimer@redhat.com> writes: > * Jeff Law: > >> On 11/20/23 02:55, Florian Weimer wrote: >>> This revision addresses Marek's comment about handing >>> -Wdeclaration-missing-parameter-type properly in conjunction with >>> -fpermissive. A new test (permerror-fpermissive-nowarning.c) >>> demonstrates the expected behavior. I added a test for -std=gnu89 >>> -fno-permissive, too. >>> I'm including the precursor cleanup patches in this posting. >>> Hopefully >>> this will make the aarch64 tester happy. >>> Thanks, >>> Florian >>> Florian Weimer (11): >>> aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder >>> aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c >>> gm2: Add missing declaration of m2pim_M2RTS_Terminate to test >>> Add tests for validating future C permerrors >>> c: Turn int-conversion warnings into permerrors >>> c: Turn -Wimplicit-function-declaration into a permerror >>> c: Turn -Wimplicit-int into a permerror >>> c: Do not ignore some forms of -Wimplicit-int in system headers >>> c: Turn -Wreturn-mismatch into a permerror >>> c: Turn -Wincompatible-pointer-types into a permerror >>> c: Add new -Wdeclaration-missing-parameter-type permerror > >> The series is fine by me. > > Thanks. > >> But give Marek additional time to chime in, particularly given the >> holidays this week in the US. Say through this time next week? > > [...] > > I'm also gathering some numbers regarding autoconf impact and potential > silent miscompilation. I'd actually forgot about another element here: FreeBSD 14 which was just released now ships with Clang 16 so we seem to be getting some activity from them which is a help. I've resumed our testing for configure diffs and am going to focus on that for now. It's just laborious because of how many errors are actually fine.
* Sam James: >>> But give Marek additional time to chime in, particularly given the >>> holidays this week in the US. Say through this time next week? >> >> [...] >> >> I'm also gathering some numbers regarding autoconf impact and potential >> silent miscompilation. > > I'd actually forgot about another element here: FreeBSD 14 which was > just released now ships with Clang 16 so we seem to be getting some > activity from them which is a help. > > I've resumed our testing for configure diffs and am going to > focus on that for now. It's just laborious because of how many errors > are actually fine. Marek has kindly posted his reviews, and I'm incorporating his suggestions. Meanwhile, I've posted some numbers to the gcc list: Update on GCC 14 C type safety changes/warnings as errors <https://inbox.sourceware.org/gcc/87ttp3tek1.fsf@oldenburg.str.redhat.com/> Thanks, Florian