| Message ID | 5c3d0ab5baa9126b544a8f54ac5c773269ee1944.1648531197.git.lhjeff911@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add thermal control driver for Sunplus SP7021 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 29 Mar 2022 13:24:32 +0800, Li-hao Kuo wrote: > Add bindings for Sunplus SP7021 thermal driver > > Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com> > --- > Changes in v6: > - Modify yaml file. > - Addressed comments from Mr. Krzysztof Kozlowski > > .../bindings/thermal/sunplus-thermal.yaml | 43 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/thermal/sunplus-thermal.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1610480 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 29/03/2022 07:24, Li-hao Kuo wrote: > Add bindings for Sunplus SP7021 thermal driver > > Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com> > --- > Changes in v6: > - Modify yaml file. > - Addressed comments from Mr. Krzysztof Kozlowski No, you did not address. If you think otherwise, please provide some context because I really do not see any change here. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml new file mode 100644 index 0000000..80d70ff --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (C) Sunplus Co., Ltd. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/sunplus_thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sunplus Thermal controller + +maintainers: + - Li-hao Kuo <lhjeff911@gmail.com> + +properties: + compatible: + enum: + - sunplus,sp7021-thermal + + reg: + maxItems: 1 + + nvmem-cells: + maxItems: 1 + + nvmem-cell-names: + const: therm_calib + +required: + - compatible + - reg + - nvmem-cells + - nvmem-cell-names + +additionalProperties: false + +examples: + - | + thermal@9c000280 { + compatible = "sunplus,sp7021-thermal"; + reg = <0x9c000280 0xc>; + nvmem-cells = <&calib>; + nvmem-cell-names = "therm_calib"; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 4096763..51a94c8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18864,6 +18864,7 @@ SUNPLUS THERMAL DRIVER M: Li-hao Kuo <lhjeff911@gmail.com> L: linux-pm@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml F: drivers/thermal/sunplus_thermal.c SUNPLUS UART DRIVER
Add bindings for Sunplus SP7021 thermal driver Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com> --- Changes in v6: - Modify yaml file. - Addressed comments from Mr. Krzysztof Kozlowski .../bindings/thermal/sunplus-thermal.yaml | 43 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml